Skip to content

[Fix][UI] Add loading before file modification data is returned.#10450

Merged
Amy0104 merged 1 commit intoapache:devfrom
Amy0104:fix/10033
Jun 15, 2022
Merged

[Fix][UI] Add loading before file modification data is returned.#10450
Amy0104 merged 1 commit intoapache:devfrom
Amy0104:fix/10033

Conversation

@Amy0104
Copy link
Copy Markdown
Member

@Amy0104 Amy0104 commented Jun 15, 2022

Purpose of the pull request

This pull request adds loading before file modification data is returned.

Related Issue

#10033

@Amy0104 Amy0104 added UI ui and front end related e2e e2e test labels Jun 15, 2022
@Amy0104 Amy0104 self-assigned this Jun 15, 2022
@Amy0104 Amy0104 requested a review from songjianet as a code owner June 15, 2022 06:20
@Amy0104 Amy0104 added this to the 3.0.0-beta-2 milestone Jun 15, 2022
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amy0104 Amy0104 merged commit d516369 into apache:dev Jun 15, 2022
@SbloodyS SbloodyS deleted the fix/10033 branch June 15, 2022 07:26
@zhongjiajie
Copy link
Copy Markdown
Member

Great and it make our E2E more stable 👍

devosend pushed a commit that referenced this pull request Jun 18, 2022
hstdream pushed a commit to hstdream/dolphinscheduler that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e e2e test UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants