Skip to content

[Feature][Metrics] Enable prometheus to collect metrics in standalone mode demo #10398

Merged
kezhenxu94 merged 2 commits intoapache:devfrom
EricGao888:Fix-10395
Jun 10, 2022
Merged

[Feature][Metrics] Enable prometheus to collect metrics in standalone mode demo #10398
kezhenxu94 merged 2 commits intoapache:devfrom
EricGao888:Fix-10395

Conversation

@EricGao888
Copy link
Copy Markdown
Member

@EricGao888 EricGao888 commented Jun 10, 2022

Purpose of the pull request

Brief change log

  • Already described above.

Verify this pull request

  • Verified by manual test.
    metrics

@EricGao888
Copy link
Copy Markdown
Member Author

@ruanwenjun May I ask what is this 8080 port for? Thx

- 'host.docker.internal:8080' # Change the address to the DolphinScheduler standalone server

@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly backend metrics labels Jun 10, 2022
@ruanwenjun
Copy link
Copy Markdown
Member

ruanwenjun commented Jun 10, 2022

@ruanwenjun May I ask what is this 8080 port for? Thx

- 'host.docker.internal:8080' # Change the address to the DolphinScheduler standalone server

In my knowledge, the port 8080 is not being used, in standalone, use port 12345 and change the metrics_path to dolphinscheduler/actuator/prometheus is OK.

So you can remove the port 8080.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 10, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.56%. Comparing base (3258438) to head (d0013d4).
⚠️ Report is 2207 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #10398   +/-   ##
=========================================
  Coverage     40.56%   40.56%           
- Complexity     4766     4769    +3     
=========================================
  Files           877      877           
  Lines         35621    35621           
  Branches       3945     3945           
=========================================
+ Hits          14449    14450    +1     
  Misses        19737    19737           
+ Partials       1435     1434    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EricGao888
Copy link
Copy Markdown
Member Author

@ruanwenjun May I ask what is this 8080 port for? Thx

- 'host.docker.internal:8080' # Change the address to the DolphinScheduler standalone server

In my knowledge, the port 8080 is not being used, in standalone, use port 12345 and change the metrics_path to dolphinscheduler/actuator/prometheus is OK.

So you can remove the port 8080.

Sure, thx

Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kezhenxu94 kezhenxu94 merged commit e6d3991 into apache:dev Jun 10, 2022
ITBOX-ITBOY pushed a commit to ITBOX-ITBOY/dolphinscheduler that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend improvement make more easy to user or prompt friendly metrics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Metrics] Enable prometheus to collect metrics in standalone mode demo

5 participants