Add dolphinscheduler-scheduler module#10360
Conversation
kezhenxu94
left a comment
There was a problem hiding this comment.
Some files are missing license headers
| <artifactId>dolphinscheduler</artifactId> | ||
| <groupId>org.apache.dolphinscheduler</groupId> | ||
| <version>dev-SNAPSHOT</version> | ||
| </parent> |
There was a problem hiding this comment.
Do we need this? This module should be added only in starter, like api, master, worker, alert
There was a problem hiding this comment.
This is mistake, the parent should be dolphinscheduler-scheduler-plugin
pom.xml
Outdated
| <module>dolphinscheduler-log-server</module> | ||
| <module>dolphinscheduler-tools</module> | ||
| <module>dolphinscheduler-ui</module> | ||
| <module>dolphinscheduler-scheduler</module> |
There was a problem hiding this comment.
Can we rename to the same formats as other plugins? Like dolphinscheduler-scheduler-plugin-quartz
| <artifactId>cron-utils</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.quartz-scheduler</groupId> |
There was a problem hiding this comment.
Hey I don't have my computer at hands, do we still depend on this module in -service module?
There was a problem hiding this comment.
Right now, we have some class rely on the quartz module to do some cron parsing. We need to refactor the CronUtils, then we can remove the org.quartz-scheduler module. I add a todo in CronUtils, it will take some to refactor this util.
| /** | ||
| * This is the interface for scheduler, contains methods to operate schedule task. | ||
| */ | ||
| public interface SchedulerApi { |
There was a problem hiding this comment.
What about extends AutoCloseable?
685a57f to
42d41fa
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
good job |
* Add dolphinscheduler-scheduler module
* Add dolphinscheduler-scheduler module * delete unused class in SchedulerServiceTest
* Add dolphinscheduler-scheduler module Co-authored-by: Wenjun Ruan <wenjun@apache.org>
* Add dolphinscheduler-scheduler module (apache#10360) * Add dolphinscheduler-scheduler module * Add dolphinscheduler-scheduler module (apache#10360) * Add dolphinscheduler-scheduler module * delete unused class in SchedulerServiceTest Co-authored-by: Wenjun Ruan <wenjun@apache.org>
* Add dolphinscheduler-scheduler module
Purpose of the pull request
Split the quartz from service module.
Brief change log
SchedulerApi, contains addOrInsert/delete method to operate schedule task.