[Feature][metrics] Add master, worker metrics#10326
Merged
caishunfeng merged 12 commits intoapache:devfrom Jun 9, 2022
Merged
Conversation
df5ec66 to
03f4025
Compare
Codecov Report
@@ Coverage Diff @@
## dev #10326 +/- ##
============================================
- Coverage 40.56% 40.45% -0.12%
- Complexity 4739 4740 +1
============================================
Files 869 874 +5
Lines 35273 35465 +192
Branches 3935 3938 +3
============================================
+ Hits 14309 14347 +38
- Misses 19534 19689 +155
+ Partials 1430 1429 -1
Continue to review full report at Codecov.
|
393f1c5 to
d2ee18a
Compare
Member
Author
|
@EricGao888 Please take a look. |
kezhenxu94
reviewed
Jun 6, 2022
Member
kezhenxu94
left a comment
There was a problem hiding this comment.
Nice metrics improvements, I left some comments
dolphinscheduler-meter/src/main/java/org/apache/dolphinscheduler/meter/MeterConfiguration.java
Show resolved
Hide resolved
caishunfeng
reviewed
Jun 7, 2022
Contributor
caishunfeng
left a comment
There was a problem hiding this comment.
some not important things
fd5f206 to
992f4fa
Compare
fbc38a4 to
2653db9
Compare
|
SonarCloud Quality Gate failed. |
caishunfeng
approved these changes
Jun 9, 2022
14 tasks
ITBOX-ITBOY
pushed a commit
to ITBOX-ITBOY/dolphinscheduler
that referenced
this pull request
Jul 8, 2022
* Add mater metrics * fix UT * Add url to mysql profile * Add worker metrics * Update grafana config * Add system metrics doc * Add process failover counter * Add metrics image * Change jpg to png * Add command insert metrics * Fix UT * Revert UT
ruanwenjun
added a commit
that referenced
this pull request
Jul 19, 2022
* Add mater metrics * fix UT * Add url to mysql profile * Add worker metrics * Update grafana config * Add system metrics doc * Add process failover counter * Add metrics image * Change jpg to png * Add command insert metrics * Fix UT * Revert UT (cherry picked from commit e21d7b1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
related issue #9324
Brief change log
Add basic metrics about master server.
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: