Skip to content

[Feature-10290] [API] Refactor org.apache.dolphinscheduler.api.controller.AccessTokenController#createToken api#10301

Merged
SbloodyS merged 9 commits intoapache:devfrom
SbloodyS:feature_10290
May 31, 2022
Merged

[Feature-10290] [API] Refactor org.apache.dolphinscheduler.api.controller.AccessTokenController#createToken api#10301
SbloodyS merged 9 commits intoapache:devfrom
SbloodyS:feature_10290

Conversation

@SbloodyS
Copy link
Copy Markdown
Member

Purpose of the pull request

close #10290


@SbloodyS SbloodyS requested a review from kezhenxu94 as a code owner May 30, 2022 13:42
@SbloodyS SbloodyS requested a review from kezhenxu94 May 30, 2022 14:02
@SbloodyS SbloodyS requested a review from kezhenxu94 May 30, 2022 14:22
kezhenxu94
kezhenxu94 previously approved these changes May 30, 2022
@SbloodyS SbloodyS self-assigned this May 30, 2022
@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly backend labels May 30, 2022
caishunfeng
caishunfeng previously approved these changes May 31, 2022
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #10301 (7c8700d) into dev (8d26d4f) will decrease coverage by 0.27%.
The diff coverage is 98.11%.

@@             Coverage Diff              @@
##                dev   #10301      +/-   ##
============================================
- Coverage     41.15%   40.87%   -0.28%     
- Complexity     4772     4822      +50     
============================================
  Files           857      869      +12     
  Lines         34659    35323     +664     
  Branches       3828     3933     +105     
============================================
+ Hits          14263    14439     +176     
- Misses        19019    19435     +416     
- Partials       1377     1449      +72     
Impacted Files Coverage Δ
...nscheduler/api/configuration/AppConfiguration.java 94.11% <ø> (ø)
...duler/api/service/impl/AccessTokenServiceImpl.java 82.95% <80.00%> (-3.47%) ⬇️
...phinscheduler/api/configuration/SwaggerConfig.java 100.00% <100.00%> (ø)
...cheduler/api/controller/AccessTokenController.java 87.50% <100.00%> (-0.74%) ⬇️
...eduler/api/controller/AccessTokenV2Controller.java 100.00% <100.00%> (ø)
...e/dolphinscheduler/api/dto/CreateTokenRequest.java 100.00% <100.00%> (ø)
.../dolphinscheduler/api/dto/CreateTokenResponse.java 100.00% <100.00%> (ø)
...permission/ResourcePermissionCheckServiceImpl.java 5.08% <0.00%> (-18.92%) ⬇️
...scheduler/api/service/impl/UdfFuncServiceImpl.java 71.42% <0.00%> (-14.03%) ⬇️
...inscheduler/api/service/impl/UsersServiceImpl.java 71.96% <0.00%> (-8.71%) ⬇️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d26d4f...7c8700d. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@SbloodyS SbloodyS added this to the 4.0.0-alpha milestone May 31, 2022
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@SbloodyS SbloodyS merged commit 8c72552 into apache:dev May 31, 2022
@SbloodyS SbloodyS deleted the feature_10290 branch May 31, 2022 06:01
ITBOX-ITBOY pushed a commit to ITBOX-ITBOY/dolphinscheduler that referenced this pull request Jul 8, 2022
…ller.AccessTokenController#createToken api (apache#10301)

* add feature_10290

* fix dolphinscheduler-ui/pnpm-lock.yaml error

* fix dolphinscheduler-ui/pnpm-lock.yaml error

* fix incorrect dependency

* fix incorrect dependency and unit test

* fix unit test error

* add dolphinscheduler-api/logs to .gitignore

* add AccessTokenV2ControllerTest.java

* fix AccessTokenV2ControllerTest error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend improvement make more easy to user or prompt friendly

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

[API] Refactor org.apache.dolphinscheduler.api.controller.AccessTokenController#createToken api

5 participants