Skip to content

[Feature][Task Plugin] Add support for dynamic form in zeppelin task#10269

Merged
Amy0104 merged 1 commit intoapache:devfrom
EricGao888:Fix-9977
May 31, 2022
Merged

[Feature][Task Plugin] Add support for dynamic form in zeppelin task#10269
Amy0104 merged 1 commit intoapache:devfrom
EricGao888:Fix-9977

Conversation

@EricGao888
Copy link
Copy Markdown
Member

@EricGao888 EricGao888 commented May 27, 2022 •
edited
Loading

Purpose of the pull request

Brief change log

  • Enable users to pass parameter in json format to dynamic form in zeppelin notes.
  • Related backend, UI and docs are updated.

Verify this pull request

  • Verified by unit tests and manual tests.

@SbloodyS SbloodyS added feature new feature backend improvement make more easy to user or prompt friendly UI ui and front end related and removed feature new feature labels May 27, 2022
@mergeable mergeable bot removed the UI ui and front end related label May 27, 2022
@SbloodyS SbloodyS added the UI ui and front end related label May 27, 2022
@songjianet
Copy link
Copy Markdown
Member

songjianet commented May 27, 2022

Please associate the corresponding issue. @EricGao888

@EricGao888
Copy link
Copy Markdown
Member Author

EricGao888 commented May 27, 2022 •
edited
Loading

Please associate the corresponding issue. @EricGao888

Thx for the reminder. Related issue added. : )

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.9% 90.9% Coverage
0.0% 0.0% Duplication

@zhongjiajie zhongjiajie added this to the 3.1.0-alpha milestone May 30, 2022
zhongjiajie
zhongjiajie approved these changes May 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the docs and backend code, PTAL the front end part @songjianet

labbomb
labbomb approved these changes May 31, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricGao888 EricGao888 requested a review from zhongjiajie May 31, 2022 02:44
devosend
devosend approved these changes May 31, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@devosend devosend left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the front end

songjianet
songjianet approved these changes May 31, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amy0104 Amy0104 self-requested a review May 31, 2022 03:18
Amy0104
Amy0104 approved these changes May 31, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Amy0104 Amy0104 merged commit a8a5da3 into apache:dev May 31, 2022
@zhongjiajie
Copy link
Copy Markdown
Member

zhongjiajie commented May 31, 2022 •
edited
Loading

cool~ thank @EricGao888

ITBOX-ITBOY pushed a commit to ITBOX-ITBOY/dolphinscheduler that referenced this pull request Jul 8, 2022
@EricGao888
[Feature][Task Plugin] Add support for dynamic form for zeppelin task…
139ce1e 
… plugin (apache#9977) (apache#10269)
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 41.25%. Comparing base (4c1ef0a) to head (8ce2aa5).
⚠️ Report is 2282 commits behind head on dev.

Files with missing lines Patch % Lines
...inscheduler/plugin/task/zeppelin/ZeppelinTask.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                dev   #10269   +/-   ##
=========================================
  Coverage     41.25%   41.25%           
- Complexity     4760     4761    +1     
=========================================
  Files           854      854           
  Lines         34579    34587    +8     
  Branches       3821     3822    +1     
=========================================
+ Hits          14265    14270    +5     
- Misses        18944    18945    +1     
- Partials       1370     1372    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devosend devosend devosend approved these changes

@labbomb labbomb labbomb approved these changes

@songjianet songjianet songjianet approved these changes

@Amy0104 Amy0104 Amy0104 approved these changes

@Tianqi-Dotes Tianqi-Dotes Awaiting requested review from Tianqi-Dotes

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

Assignees

@EricGao888 EricGao888

Labels

backend improvement make more easy to user or prompt friendly UI ui and front end related

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

[Feature][Task Plugin] Add support for dynamic form for zeppelin task plugin

8 participants

@EricGao888 @songjianet @zhongjiajie @codecov-commenter @devosend @labbomb @Amy0104 @SbloodyS