Skip to content

[doc] Add switch task demo#10247

Merged
zhongjiajie merged 8 commits intoapache:devfrom
huangchenguang123:feature/add_switch_demo
Jun 8, 2022
Merged

[doc] Add switch task demo#10247
zhongjiajie merged 8 commits intoapache:devfrom
huangchenguang123:feature/add_switch_demo

Conversation

@huangchenguang123
Copy link
Copy Markdown
Contributor

close #8029

Copy link
Copy Markdown
Contributor

@QuakeWang QuakeWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the screenshots corresponding to the documentation are recommended to be in light mode. Thanks a lot : )

Copy link
Copy Markdown
Contributor

@QuakeWang QuakeWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided images can be marked with corresponding tags at key information. In this way, it can be more beneficial to users.

@@ -1,10 +1,12 @@
# Switch

Switch是一个条件判断节点,依据[全局变量](../parameter/global.md)的值和用户所编写的表达式判断结果执行对应分支。
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to use the original expression, which is more complete.

@@ -14,26 +15,33 @@ Drag from the toolbar <img src="/img/switch.png" width="20"/> task node to canv
- Descriptive information: Describe the function of the node.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra indent spaces

@huangchenguang123
Copy link
Copy Markdown
Contributor Author

@QuakeWang Thanks.I had fixed those problems.

@huangchenguang123
Copy link
Copy Markdown
Contributor Author

I had fixed those problems.

Co-authored-by: QuakeWang <45645138+QuakeWang@users.noreply.github.com>
@zhongjiajie
Copy link
Copy Markdown
Member

zhongjiajie commented May 30, 2022

I find out we still have a discussion in #10247 (comment) and I do not have much experience for switch tasks. Maybe you guys should discuss on it

@huangchenguang123
Copy link
Copy Markdown
Contributor Author

I find out we still have a discussion in #10247 (comment) and I do not have much experience for switch tasks. Maybe you guys should discuss on it

What do you think about it?Do you have more suggestions? @QuakeWang

QuakeWang
QuakeWang previously approved these changes Jun 5, 2022
Copy link
Copy Markdown
Contributor

@QuakeWang QuakeWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR sets the corresponding switch branch using global variables. In this way, users can intuitively understand how to use this task.

zhongjiajie
zhongjiajie previously approved these changes Jun 6, 2022
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huangchenguang123 and @QuakeWang for the review

@zhongjiajie zhongjiajie changed the title [fix][doc]: add switch task demo [doc] Add switch task demo Jun 6, 2022
@zhongjiajie zhongjiajie dismissed stale reviews from QuakeWang and themself via 87c6a38 June 6, 2022 01:35
@zhongjiajie
Copy link
Copy Markdown
Member

I solve some upstream change in branch dev

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

img path usage

The switch task needs to be connected with the downstream task to configure the relationship before the downstream task can be selected.

## Related Task
![switch_01](/img/tasks/demo/switch_01.png)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use related path instead of absolute path after #10325 merged

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had change the img path.

@huangchenguang123
Copy link
Copy Markdown
Contributor Author

PTAL @zhongjiajie

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks

@zhongjiajie zhongjiajie merged commit 7e39e0d into apache:dev Jun 8, 2022
devosend pushed a commit that referenced this pull request Jun 17, 2022
Co-authored-by: QuakeWang <45645138+QuakeWang@users.noreply.github.com>
(cherry picked from commit 7e39e0d)
@huangchenguang123 huangchenguang123 deleted the feature/add_switch_demo branch June 21, 2022 06:14
ITBOX-ITBOY pushed a commit to ITBOX-ITBOY/dolphinscheduler that referenced this pull request Jul 8, 2022
Co-authored-by: QuakeWang <45645138+QuakeWang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Document] Add example and notice about task type Switch

4 participants