Skip to content

feat: support pg type alias #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alamb merged 2 commits into from
Jul 27, 2023
Merged

feat: support pg type alias #933

alamb merged 2 commits into from
Jul 27, 2023

Conversation

@Kikkon
Copy link
Contributor

@Kikkon Kikkon commented Jul 23, 2023 •
edited
Loading

fix: #931

@Kikkon Kikkon marked this pull request as ready for review July 24, 2023 04:07
@Kikkon
Copy link
Contributor Author

Kikkon commented Jul 24, 2023

I'd appreciate it if you could give me some feedback on this PR whenever you have time. @alamb

@alamb
Copy link
Contributor

alamb commented Jul 25, 2023

Thanks -- I will try and get to it later this week @Kikkon

alamb
alamb reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kikkon -- thank you for the contribution. I think this looks like a good approach and I especially like that it is fairly backwards compatible (doesn't change existing variants, just adds new ones)

It looks like there are some CI tests to fix but then this one should be good to go!

src/ast/data_type.rs
/// Unsigned big integer with optional display width e.g. BIGINT UNSIGNED or BIGINT(20) UNSIGNED
UnsignedBigInt(Option<u64>),
/// Int8 as alias for Bigint in [postgresql]
/// Note: Int8 mean 8 bytes in postgres (not 8 bits)
Copy link
Contributor

@alamb alamb Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the nice comments

@coveralls
Copy link

coveralls commented Jul 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5675972403

  • 52 of 74 (70.27%) changed or added relevant lines in 3 files are covered.
  • 434 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.09%) to 87.069%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 11 18 61.11%
src/ast/data_type.rs 0 15 0.0%
Files with Coverage Reduction New Missed Lines %
src/ast/data_type.rs 2 80.52%
tests/sqlparser_common.rs 17 97.19%
src/parser.rs 415 83.02%
Totals Coverage Status
Change from base Build 5621232803: -0.09%
Covered Lines: 15513
Relevant Lines: 17817
💛 - Coveralls

@Kikkon
Copy link
Contributor Author

Kikkon commented Jul 27, 2023 •
edited
Loading

Hi @Kikkon -- thank you for the contribution. I think this looks like a good approach and I especially like that it is fairly backwards compatible (doesn't change existing variants, just adds new ones)

It looks like there are some CI tests to fix but then this one should be good to go!

Already fixed the CI tests. @alamb

alamb
alamb approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kikkon

@alamb alamb merged commit 0ddb853 into apache:main Jul 27, 2023
@Kikkon Kikkon mentioned this pull request Jul 31, 2023
Closed
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
@Kikkon @serprex
feat: support pg type alias (apache#933)
eb7f186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support postgres types transparently in queries

3 participants

@Kikkon @alamb @coveralls