Skip to content

Adds support for PostgreSQL "END" #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alamb merged 3 commits into from
Nov 21, 2023
Merged

Adds support for PostgreSQL "END" #1035

alamb merged 3 commits into from
Nov 21, 2023

Conversation

@tobyhede
Copy link
Contributor

@tobyhede tobyhede commented Nov 2, 2023

Related to #1034

Adds support for treating END as COMMIT.
END is still used as a statement delimiter, but we only check this case if expecting a statement to end.

I am not 100% sure this is the right approach, but the tests pass.

@coveralls
Copy link

coveralls commented Nov 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6938222562

  • 7 of 8 (87.5%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 87.706%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
src/parser/mod.rs 1 83.22%
Totals Coverage Status
Change from base Build 6937704001: -0.001%
Covered Lines: 17900
Relevant Lines: 20409
💛 - Coveralls

alamb
alamb approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @tobyhede 🙏

@tobyhede
Adds support for PostgreSQL "END"
60eb8ba 
Signed-off-by: Toby Hede <toby@cipherstash.com>
@tobyhede
Fix for lint warning
9d7c62d
@tobyhede
Remove old comment
5f26140 
Signed-off-by: Toby Hede <toby@cipherstash.com>
@alamb alamb merged commit 541d684 into apache:main Nov 21, 2023
@alamb
Copy link
Contributor

alamb commented Nov 21, 2023

Thanks again @tobyhede

@serprex serprex mentioned this pull request Dec 11, 2023
Merged
serprex added a commit to PeerDB-io/sqlparser-rs that referenced this pull request Dec 11, 2023
@serprex
Merge pull request #28 from PeerDB-io/merge-upstream
e2a651a 
Merge 0.40 + apache/datafusion-sqlparser-rs#1040

Upstream implemented END parsing as COMMIT on postgresql: apache/datafusion-sqlparser-rs#1035 allowing some convergence
@tobyhede tobyhede deleted the fix/postgres-end branch August 27, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tobyhede @coveralls @alamb