Skip to content

chore: Address reviews#920

Merged
viirya merged 1 commit intoapache:mainfrom
viirya:address_reviews
Sep 7, 2024
Merged

chore: Address reviews#920
viirya merged 1 commit intoapache:mainfrom
viirya:address_reviews

Conversation

@viirya
Copy link
Copy Markdown
Member

@viirya viirya commented Sep 6, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

Addressing the latest reviews #905 (comment) and #905 (comment).

What changes are included in this PR?

How are these changes tested?

@viirya
Copy link
Copy Markdown
Member Author

viirya commented Sep 6, 2024

cc @Kontinuation

Copy link
Copy Markdown
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viirya

@viirya viirya merged commit 2a37b88 into apache:main Sep 7, 2024
@viirya
Copy link
Copy Markdown
Member Author

viirya commented Sep 7, 2024

Thanks @andygrove

@viirya viirya deleted the address_reviews branch September 7, 2024 00:04
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants