chore: Move temporal kernels and expressions to spark-expr crate #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
=============================================
+ Coverage 33.65% 53.88% +20.23%
+ Complexity 842 811 -31
=============================================
Files 109 106 -3
Lines 42573 10238 -32335
Branches 9334 1916 -7418
=============================================
- Hits 14328 5517 -8811
+ Misses 25297 3744 -21553
+ Partials 2948 977 -1971 ☔ View full report in Codecov by Sentry. |
kazuyukitanimura
approved these changes
Jul 15, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
…che#660) * Move temporal expressions to spark-expr crate * reduce public api * reduce public api * update imports in benchmarks * fmt * remove unused dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #659
Rationale for this change
Ongoing work to move expressions to separate crate so that other projects can use them without depending on all of Comet.
What changes are included in this PR?
pubtopub(crate)because they should not be part of a public APIHow are these changes tested?
Existing tests.