fix: Fix shuffle writing rows containing null struct fields #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1845 +/- ##
============================================
+ Coverage 56.12% 59.40% +3.28%
- Complexity 976 1151 +175
============================================
Files 119 130 +11
Lines 11743 12663 +920
Branches 2251 2374 +123
============================================
+ Hits 6591 7523 +932
+ Misses 4012 3930 -82
- Partials 1140 1210 +70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
reviewed
Jun 4, 2025
| } | ||
|
|
||
| #[test] | ||
| #[cfg_attr(miri, ignore)] // Unaligned memory access in SparkUnsafeRow |
Member
There was a problem hiding this comment.
Do we want to file a follow-on issue to remove the unaligned memory access?
Member
|
I confirmed that this does also close #1823 |
This was referenced Jun 5, 2025
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1844 and probably #1823.
Rationale for this change
Loading data with custom schema may produce rows containing null struct fields. Shuffling such null struct fields throws exceptions mentioned in the linked issues.
What changes are included in this PR?
Fixes appending null rows to
StructBuilderby making children field builders always in sync with the parent struct builder.How are these changes tested?
append_fieldin native code