fix: Handle case where num_cols == 0 in native execution #1840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1840 +/- ##
============================================
+ Coverage 56.12% 59.41% +3.29%
- Complexity 976 1151 +175
============================================
Files 119 130 +11
Lines 11743 12663 +920
Branches 2251 2374 +123
============================================
+ Hits 6591 7524 +933
+ Misses 4012 3930 -82
- Partials 1140 1209 +69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
comphead
approved these changes
Jun 4, 2025
Contributor
comphead
left a comment
There was a problem hiding this comment.
lgtm thanks @andygrove
wondeering why the test is specifc for CometConf.COMET_SHUFFLE_MODE.key -> "jvm")
Member
Author
This issue only happened in the Spark SQL version of the test when it was using jvm shuffle, but I didn't check if this repro has the same issue with native shuffle. |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1251
Rationale for this change
Fix a Spark SQL test failure when jvm shuffle is enabled.
What changes are included in this PR?
New test and bug fix.
How are these changes tested?