chore: Run Comet tests for more Spark versions #1582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1582 +/- ##
============================================
+ Coverage 56.12% 58.65% +2.52%
- Complexity 976 1028 +52
============================================
Files 119 123 +4
Lines 11743 12421 +678
Branches 2251 2337 +86
============================================
+ Hits 6591 7285 +694
+ Misses 4012 3965 -47
- Partials 1140 1171 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
parthchandra
approved these changes
Apr 1, 2025
kazuyukitanimura
approved these changes
Apr 1, 2025
Comment on lines
+105
to
+107
| - if: matrix.test-target == 'rust' | ||
| name: Rust test steps | ||
| uses: ./.github/actions/rust-test |
Contributor
There was a problem hiding this comment.
nit: the rust test seems to be redundant, but ok
Member
Author
There was a problem hiding this comment.
I agree. We also run the rust tests for multiple spark versions which is also redundant. I will create a follow-on PR to improve.
Contributor
|
Thanks @andygrove @parthchandra |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
## Which issue does this PR close? Closes apache#1579 ## Rationale for this change Run Comet tests for 3.5.2 through 3.5.4 to avoid introducing regressions for those releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1579
Rationale for this change
Run Comet tests for 3.5.2 through 3.5.4 to avoid introducing regressions for those releases
What changes are included in this PR?
How are these changes tested?