Remove circular dependency #9279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
reviewed
Feb 19, 2024
|
|
||
| [dev-dependencies] | ||
| criterion = "0.5" | ||
| datafusion = { workspace = true } |
Member
There was a problem hiding this comment.
Hm, why we added this dependency. Looks not correct. 🤔
Member
Author
There was a problem hiding this comment.
It looks like it was added to allow for some example code in rustdoc.
Contributor
There was a problem hiding this comment.
Sorry I missed this on initial review.
viirya
approved these changes
Feb 19, 2024
viirya
reviewed
Feb 19, 2024
| /// # Examples | ||
| /// | ||
| /// ``` | ||
| /// ```ignore |
comphead
approved these changes
Feb 19, 2024
Contributor
comphead
left a comment
There was a problem hiding this comment.
Thanks @andygrove are you planning to merge it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9277
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?