Skip to content

Conversation

@jonahgao
Copy link
Member

Which issue does this PR close?

N/A

Rationale for this change

Reported by rust-analyzer diagnostics.

c632bef6-c8cc-4f32-a731-2cf38b4b0288_capture

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

No

Copy link
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 👍

Interesting that cargo fmt didn't catch this 🤔

@jonahgao
Copy link
Member Author

Nice cleanup 👍

Interesting that cargo fmt didn't catch this 🤔

It seems that cargo-fmt has not covered these files, which might be related to creating modules within macros. I need to investigate it further.

@comphead
Copy link
Contributor

Nice cleanup 👍

Interesting that cargo fmt didn't catch this 🤔

I have the same question.....

@comphead comphead merged commit 5291b03 into apache:main Feb 19, 2024
@jonahgao jonahgao deleted the unused_braces branch February 20, 2024 01:37
@jonahgao
Copy link
Member Author

Nice cleanup 👍
Interesting that cargo fmt didn't catch this 🤔

I have the same question.....

Filled a new issue #9281.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants