-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
Found in #9271 and occurred in the 'datafusion-functions' package.
cargo-fmt starts at the crate root and traverses submodules to find files, but it does not parse modules declared inside macros, thus files within these modules will not be processed. Additionally, only certain macros are exceptions, such as cfg_if.
We are using the make_package macro in the functions package to define modules.
https://github.com/apache/arrow-datafusion/blob/cf92f3b01ff064308c5e7ca2e15c20770d48a88a/datafusion/functions/src/macros.rs#L102-L107
Upstream issue: rust-lang/rustfmt#3253
To Reproduce
Run the shell commands under the repo directory.
rustfmt datafusion/functions/src/*/*.rs
git statusAnd here is also a minimal repo to reproduce it.
Expected behavior
All rust files should be formatted.
Additional context
No response
Jefffrey
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working