fix: from_plan generate Agg can be with different schema. #6820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 2, 2023
alamb
reviewed
Jul 2, 2023
| plan: LogicalPlan, | ||
| expr: impl IntoIterator<Item = impl Into<Expr>>, | ||
| ) -> Result<LogicalPlan> { | ||
| // TODO: move it into analyzer |
jackwener
added a commit
to jackwener/arrow-datafusion
that referenced
this pull request
Jul 3, 2023
jackwener
added a commit
to jackwener/arrow-datafusion
that referenced
this pull request
Jul 3, 2023
jackwener
added a commit
to jackwener/arrow-datafusion
that referenced
this pull request
Jul 3, 2023
2010YOUY01
pushed a commit
to 2010YOUY01/arrow-datafusion
that referenced
this pull request
Jul 5, 2023
…che#6820) * fix: from_plan generate Agg can be with different schema. * fix: from_plan generate Window can be with different schema.
2010YOUY01
pushed a commit
to 2010YOUY01/arrow-datafusion
that referenced
this pull request
Jul 5, 2023
* revert: from_plan keep same schema Project in apache#6595 * revert: from_plan keep same schema Agg/Window in apache#6820 * revert type coercion * add comment
yukkit
pushed a commit
to cnosdb/arrow-datafusion
that referenced
this pull request
Jul 10, 2023
* revert: from_plan keep same schema Project in apache#6595 * revert: from_plan keep same schema Agg/Window in apache#6820 * revert type coercion * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
when from_plan param use different expr, it can generate different schema
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?