Add option param for standalone mode #42
Conversation
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
- Coverage 76.24% 76.24% -0.01%
==========================================
Files 134 134
Lines 23023 23053 +30
==========================================
+ Hits 17554 17576 +22
- Misses 5469 5477 +8
Continue to review full report at Codecov.
|
|
Hi @djKooks thanks for the PR. Because you were a contributor to the Ballista code that was donated, I believe that we need you to file a contributor license agreement with the ASF before accepting further contributions. I tried reaching you during the donation process but wasn't able to. Instructions are here. Let me know if you need any help. https://www.apache.org/licenses/contributor-agreements.html Thanks! |
|
@andygrove thanks for review. Please review after it has been approved 🙏 |
…regation (#12946) * Improve unparsing for ORDER BY with Aggregation functions (#38) * Improve UNION unparsing (#39) * Scalar functions in ORDER BY unparsing support (#41) * Improve unparsing for complex Window functions with Aggregation (#42) * WindowFunction order_by should respect `supports_nulls_first_in_sort` dialect setting (#43) * Fix plan_to_sql * Improve
…he#42) Co-authored-by: Huaxin Gao <huaxin.gao@apple.com>
Related Issue
#43
Rationale for this change
Currently
StandaloneClientinstance can be created by saving data to a specific file, or to temporary file. But it executor only runs by generating temporary file, so add parameter to give specific file path.What changes are included in this PR?
It creates client with
StandaloneClient::try_new(path)if path has been defined, orStandaloneClient::try_new_temporary()if not defined.