fix: don't duplicate existing filters #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
reviewed
May 24, 2021
alamb
approved these changes
May 24, 2021
Contributor
alamb
left a comment
There was a problem hiding this comment.
Looks good to me . Thank you @e-dard
FYI @jorgecarleitao
|
|
||
| // Optimizing the same plan multiple times should produce the same plan | ||
| // each time. | ||
| assert_optimized_plan_eq(&optimised_plan, expected); |
NGA-TRAN
approved these changes
May 24, 2021
|
|
||
| // Optimizing the same plan multiple times should produce the same plan | ||
| // each time. | ||
| assert_optimized_plan_eq(&optimised_plan, expected); |
a9bfae7 to
ffca3de
Compare
Dandandan
approved these changes
May 24, 2021
jimexist
pushed a commit
to jimexist/arrow-datafusion
that referenced
this pull request
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #408
What changes are included in this PR?
This PR ensures that filter expressions already present on the table scan part of a logical plan are not re-added if the plan is run through the optimiser again.