Skip to content

Add in list bench #4068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alamb merged 5 commits into from
Nov 2, 2022
Merged

Add in list bench #4068

alamb merged 5 commits into from
Nov 2, 2022

Conversation

@tustvold
Copy link
Contributor

@tustvold tustvold commented Nov 1, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

Adds benchmarks so that I can verify #4057 doesn't cause a regression

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Nov 1, 2022
@tustvold tustvold mentioned this pull request Nov 1, 2022
Merged
liukun4515
liukun4515 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb
Copy link
Contributor

alamb commented Nov 2, 2022

I took the liberty of merging up from master and fixing a conflict

@alamb alamb merged commit 396b5aa into apache:master Nov 2, 2022
@ursabot
Copy link

ursabot commented Nov 2, 2022

Benchmark runs are scheduled for baseline = 8cd6129 and contender = 396b5aa. 396b5aa is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
@tustvold @alamb @Dandandan
Add in list bench (apache#4068)
f4f6887 
* Add InList benchmark

* Reduce cases

* Add additional test case

* RAT

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@geoffreyclaude geoffreyclaude mentioned this pull request Dec 8, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 8, 2025
@geoffreyclaude
fix: inverted null_percent logic in in_list benchmark (#19204)
662a3ba 
## Which issue does this PR close?

N/A - benchmark fix discovered during performance analysis of #18832.

## Rationale for this change

The `in_list` benchmark (introduced in #4068) had inverted null
generation logic: `null_percent=0` was producing 100% nulls instead of
0% nulls.

## What changes are included in this PR?

Fix the `random_bool(null_percent).then(...)` pattern to use
`random_bool(1.0 - null_percent)` so that `null_percent` correctly
represents the percentage of null values.

## Are these changes tested?

Benchmark-only change. Verified by running the benchmark and observing
expected performance characteristics.

## Are there any user-facing changes?

No.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dandandan Dandandan Dandandan approved these changes

@yjshen yjshen yjshen approved these changes

@liukun4515 liukun4515 liukun4515 approved these changes

Assignees

No one assigned

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tustvold @alamb @ursabot @Dandandan @yjshen @liukun4515