Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Oct 18, 2022

Which issue does this PR close?

N/A

Rationale for this change

Update config docs to reflect recent settings changes such as #3877

What changes are included in this PR?

Check in the output of running

./dev/update_config_docs.sh 

Are there any user-facing changes?

not really

@isidentical
Copy link
Contributor

This doesn't seem to include collect_statistics (probably since it is not a config option, but a session level option), is that expected @alamb?

@alamb
Copy link
Contributor Author

alamb commented Oct 19, 2022

This doesn't seem to include collect_statistics (probably since it is not a config option, but a session level option), is that expected @alamb?

@isidentical I think the core issue is that some session level configuration (such as collect_statistics is on SessionConfig and some is on ConfigOptions) -- I think we should consolidate them further #3887

@alamb alamb merged commit e8ea218 into apache:master Oct 19, 2022
@isidentical
Copy link
Contributor

@isidentical I think the core issue is that some session level configuration (such as collect_statistics is on SessionConfig and some is on ConfigOptions) -- I think we should consolidate them further #3887

Makes sense!

@alamb alamb deleted the alamb/update_config_docs branch October 19, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants