Skip to content

Update remaining crates to rust 2024 edition #19361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timsaucer merged 3 commits into from
Dec 17, 2025
Merged

Update remaining crates to rust 2024 edition #19361

timsaucer merged 3 commits into from
Dec 17, 2025

Conversation

@timsaucer
Copy link
Member

@timsaucer timsaucer commented Dec 16, 2025 •
edited
Loading

Which issue does this PR close?

Closes #15804

Rationale for this change

Now that we are on MSRV 1.88 we can use rust edition 2024, which brings let chains and other nice features. It also improves unsafe checking. In order to introduce these changes in slower way instead of one massive PR that is too difficult to manage we are updating a few crates at a time.

What changes are included in this PR?

Updates these crates to 2024.

  • datafusion-benchmarks
  • datafusion-ffi
  • datafusion-sqllogictest
  • datafusion-examples

Are these changes tested?

Existing unit tests. There are no functional code changes.

Are there any user-facing changes?

None.

Note

It is recommended to review with the ignore whitespace setting: https://github.com/apache/datafusion/pull/19361/files?w=1

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate catalog Related to the catalog crate common Related to common crate execution Related to the execution crate proto Related to proto crate functions Changes to functions implementation datasource Changes to the datasource crate ffi Changes to the ffi crate physical-plan Changes to the physical-plan crate spark labels Dec 16, 2025
@Dandandan
Copy link
Contributor

Dandandan commented Dec 17, 2025

Nice work!

@timsaucer timsaucer force-pushed the chore/upgrade-rust-2024-group-8 branch from e28c247 to 0effc95 Compare December 17, 2025 13:24
@timsaucer
Copy link
Member Author

timsaucer commented Dec 17, 2025

I'm going to merge now and then if any small CI failures happen on main I'll put up a PR to correct. Otherwise I think I'll need to keep dealing with conflicts.

@timsaucer timsaucer added this pull request to the merge queue Dec 17, 2025
Merged via the queue into apache:main with commit 59dcc36 Dec 17, 2025
30 checks passed
@timsaucer timsaucer deleted the chore/upgrade-rust-2024-group-8 branch December 17, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dandandan Dandandan Dandandan approved these changes

@Jefffrey Jefffrey Jefffrey approved these changes

Assignees

No one assigned

Labels

catalog Related to the catalog crate common Related to common crate core Core DataFusion crate datasource Changes to the datasource crate execution Related to the execution crate ffi Changes to the ffi crate functions Changes to functions implementation logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates physical-plan Changes to the physical-plan crate proto Related to proto crate spark sql SQL Planner sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update to 2024 edition

3 participants

@timsaucer @Dandandan @Jefffrey