Adds instrumentation to COPY operations in the CLI #18227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds instrumentation to copy - Adds instrumentatino to copy_if_not_exists - Adds tests for new code
alamb
approved these changes
Oct 22, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you @BlakeOrth for pushing this to the finish line
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
## Which issue does this PR close? - Closes apache#17207 ## Rationale for this change Completes the instrumentation of the object store used in datafusion-cli :tada: ## What changes are included in this PR? - Adds instrumentation to copy - Adds instrumentation to copy_if_not_exists - Adds tests for new code ## Are these changes tested? Yes. New unit tests have been added. ## Are there any user-facing changes? No-ish ## cc @alamb This PR completes the final methods for the instrumented object store! It seems like this should allow us to close the issue we've had tied to all of these PRs and additional work in this area can probably be done under new/targeted issues.
EeshanBembi
pushed a commit
to EeshanBembi/datafusion
that referenced
this pull request
Nov 24, 2025
## Which issue does this PR close? - Closes apache#17207 ## Rationale for this change Completes the instrumentation of the object store used in datafusion-cli :tada: ## What changes are included in this PR? - Adds instrumentation to copy - Adds instrumentation to copy_if_not_exists - Adds tests for new code ## Are these changes tested? Yes. New unit tests have been added. ## Are there any user-facing changes? No-ish ## cc @alamb This PR completes the final methods for the instrumented object store! It seems like this should allow us to close the issue we've had tied to all of these PRs and additional work in this area can probably be done under new/targeted issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-cli] Add a way to see what object store requests are made #17207Rationale for this change
Completes the instrumentation of the object store used in datafusion-cli 🎉
What changes are included in this PR?
Are these changes tested?
Yes. New unit tests have been added.
Are there any user-facing changes?
No-ish
cc @alamb
This PR completes the final methods for the instrumented object store! It seems like this should allow us to close the issue we've had tied to all of these PRs and additional work in this area can probably be done under new/targeted issues.