FileScanConfig: Preserve schema metadata across ser/de boundary #17966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xudong963
approved these changes
Oct 8, 2025
Member
xudong963
left a comment
There was a problem hiding this comment.
Thank you @mach-kernel , fmt needs to be fixed
milenkovicm
reviewed
Oct 8, 2025
Contributor
milenkovicm
left a comment
There was a problem hiding this comment.
thanks @mach-kernel one minor comment
Contributor
|
one other question for you @mach-kernel as you posted this in ballista group, do you need this to get to ballista 50? if so maybe we could back-port to datafusion 50.2 if @xudong963 agrees |
milenkovicm
approved these changes
Oct 8, 2025
Contributor
Author
We can wait -- though thank you for asking @milenkovicm! |
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
…he#17966) * FileScanConfig: preserve schema metadata across serde boundary * add roundtrip_physical_plan test with filescanconfig schema metadata * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
n/a
Rationale for this change
When serializing
DataSourceExecplans with aFileScanConfig, any metadata that is decorated to the schema is expected to be there after ser/deWhat changes are included in this PR?
mainAre these changes tested?
Yes
Are there any user-facing changes?
No