Adjust slttest to pass without RUST_BACKTRACE enabled #16251
Conversation
zhuqi-lucas
left a comment
There was a problem hiding this comment.
LGTM Thank you @alamb .
I am confused why CI will not fail for this case, i remember some cases i run locally to -- --complete, but the CI failed, so i add RUST_BACKTRACE to generate.
2010YOUY01
left a comment
There was a problem hiding this comment.
Thank you for the fix!
I think sqllogictest checks for substring match but So something about the entire string is different in CI but the substring does work |
|
Thank you @alamb , is it possible for --complete also generate substring which matches in CI? |
Yes, the question is what is the most important substring 🤔 Maybe just the first line would be enough |
|
Created a issue for this: |
… in values array (#16258) * Add tests * trigger ci * Update tpch, clickbench, sort_tpch to mark failed queries (#16182) * Move struct QueryResult to util/run.rs * Modify benches to continue query execution even on failure * Mark benchmark query success on output json * Adjust slttest to pass without RUST_BACKTRACE enabled (#16251) * add more tests where the dict keys are not null but dict values are null * Revert "add more tests where the dict keys are not null but dict values are null" This reverts commit c745dae. * Add tests for count and count_distinct with dictionary arrays containing null values * resolve merge conflict, reorder imports * Add helper function to create dictionary array with non-null keys and null values * Add test for count_distinct accumulator with dictionary array containing all null values * add tests to aggregate.rs * remove redundant comments in get_formatted_results function * remove redundant safety checks in count distinct dictionary test * refactor: introduce helper function for output assertion * test: add count distinct dictionary handling for null values * refactor: streamline imports and improve code organization in count.rs * fix: add missing import for batches_to_string in aggregates.rs * test: reorganize tests * refactor: simplify COUNT(DISTINCT) tests and remove unused helper functions * refactor: trim redundant tests --------- Co-authored-by: ding-young <lsyhime@snu.ac.kr> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> Co-authored-by: Dmitrii Blaginin <dmitrii@blaginin.me>
Which issue does this PR close?
Rationale for this change
Let's have sqllogictest pass locally without having to set
RUST_BACKTRACENote I didn't actually find / fix the actual underlying problem...
What changes are included in this PR?
Are these changes tested?
yes, by CI and I ran it locally as well
Are there any user-facing changes?
No
This is only a test change