Add SessionStateBuilder::with_object_store method
#12578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OussamaSaoudi
commented
Sep 22, 2024
| url: &Url, | ||
| object_store: Arc<dyn ObjectStore>, | ||
| ) -> Self { | ||
| if self.runtime_env.is_none() { |
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
I see what you mean about the existing signature: https://docs.rs/datafusion/latest/datafusion/execution/session_state/struct.SessionStateBuilder.html#method.runtime_env
This PR adds the the method `SessionStateBuilder::with_object_store`, which registers an object store with a specified URL to the RuntimeEnv.
3562b8d to
f676722
Compare
alamb
approved these changes
Sep 22, 2024
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you (again) @OussamaSaoudi -- this looks great.
I think your comments about with_runtime_env make lots of sense
| url: &Url, | ||
| object_store: Arc<dyn ObjectStore>, | ||
| ) -> Self { | ||
| if self.runtime_env.is_none() { |
Contributor
There was a problem hiding this comment.
I see what you mean about the existing signature: https://docs.rs/datafusion/latest/datafusion/execution/session_state/struct.SessionStateBuilder.html#method.runtime_env
| /// Register an `ObjectStore` to the [`RuntimeEnv`]. See [`RuntimeEnv::register_object_store`] | ||
| /// for more details. | ||
| /// | ||
| /// Note that this creates a default [`RuntimeEnv`] if there isn't one passed in already. |
Contributor
|
Thanks again @OussamaSaoudi |
bgjackma
pushed a commit
to bgjackma/datafusion
that referenced
this pull request
Sep 25, 2024
This PR adds the the method `SessionStateBuilder::with_object_store`, which registers an object store with a specified URL to the RuntimeEnv.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12553
Rationale for this change
This PR provides an API for adding
ObjectStores to aSessionStateBuilder'sRuntimeEnvby introducing the new method:SessionStateBuilder::with_object_store.What changes are included in this PR?
Are these changes tested?
I add a doctest to document and validate the new method.
Are there any user-facing changes?
None