fix: CASE with NULL #11542
Merged
fix: CASE with NULL #11542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgao
reviewed
Jul 19, 2024
datafusion/expr/src/expr_schema.rs
Outdated
| .map_or(Ok(DataType::Null), |e| e.get_type(schema))?; | ||
|
|
||
| match (then_type.clone(), else_type.clone()) { | ||
| (DataType::Null, DataType::Null) => Ok(DataType::Int64), |
Member
There was a problem hiding this comment.
There might be a problem with the following expression.
CASE data WHEN 1 THEN NULL WHEN 2 THEN 3.3 ELSE NULL END;Its type being float would be more reasonable.
Another more general fix might be to ensure that type coercion has already been performed before calling get_type, but I am not sure if that can be achieved. Therefore, the current solution is okay for me.
jonahgao
reviewed
Jul 21, 2024
Weijun-H
commented
Jul 22, 2024
Comment on lines
+117
to
+122
| for (_, then_expr) in &case.when_then_expr { | ||
| let then_type = then_expr.get_type(schema)?; | ||
| if !then_type.is_null() { | ||
| return Ok(then_type); | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
return first non-null then type here @jonahgao
jonahgao
reviewed
Jul 22, 2024
jonahgao
reviewed
Jul 22, 2024
Co-authored-by: Jonah Gao <jonahgao@msn.com>
Co-authored-by: Jonah Gao <jonahgao@msn.com>
Contributor
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Jul 23, 2024
* fix: CASE with NULL * chore: Add tests * chore * chore: Fix CI * chore: Support all types are NULL * chore: Fix CI * chore: add more tests * fix: Return first non-null type in then exprs * chore: Fix CI * Update datafusion/expr/src/expr_schema.rs Co-authored-by: Jonah Gao <jonahgao@msn.com> * Update datafusion/expr/src/expr_schema.rs Co-authored-by: Jonah Gao <jonahgao@msn.com> --------- Co-authored-by: Jonah Gao <jonahgao@msn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11258
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?