Create datafusion-physical-optimizer crate
#11507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayzhan211
reviewed
Jul 17, 2024
| workspace = true | ||
|
|
||
| [dependencies] | ||
| datafusion-common = { workspace = true, default-features = true } |
Contributor
There was a problem hiding this comment.
Is this the same as datafusion-common = { workspace = true }
Member
Author
There was a problem hiding this comment.
It might be same because datafusion-common doesn't specify default feature. I just followed datafusion-optimizer's Cargo.toml here.
18 tasks
alamb
approved these changes
Jul 17, 2024
Contributor
alamb
left a comment
There was a problem hiding this comment.
LGTM -- thanks @lewiszlw
FYI @mustafasrepo and @ozankabak
| pub mod test_utils; | ||
|
|
||
| pub use optimizer::PhysicalOptimizerRule; | ||
| pub use datafusion_physical_optimizer::*; |
Contributor
|
I like the idea of moving the physical optimizer into its own crate, thank you |
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Jul 23, 2024
* Create datafusion-physical-optimizer crate * fmt .md * Update Cargo.lock in datafusion-cli * fmt toml and fix doc
wiedld
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jul 31, 2024
* Create datafusion-physical-optimizer crate * fmt .md * Update Cargo.lock in datafusion-cli * fmt toml and fix doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11502.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?