Made UserDefinedFunctionPlanner to uniform the usages #11318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 7, 2024
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you @xinlifoobar -- this looks good to me
I agree that minimizing the number of planners is probably a good thing (as the sql planner will iterate over all planners several times, so the fewer the better in my mind)
Contributor
|
Thanks @xinlifoobar and @alamb |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11305
Rationale for this change
I moved part of the code from #11263 into this PR to reduce the # of planners we created. I read through the code and thought it is better for just one planner whole crate instead of one module for small usages...
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?