Skip to content

Conversation

@dharanad
Copy link
Contributor

@dharanad dharanad commented Jul 3, 2024

Which issue does this PR close?

Closes #11216

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Since this is minor refactor existing test cases should do

Are there any user-facing changes?

Nope

@github-actions github-actions bot added the core Core DataFusion crate label Jul 3, 2024
@dharanad dharanad marked this pull request as ready for review July 3, 2024 12:29
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect -- thank. you @dharanad

@alamb
Copy link
Contributor

alamb commented Jul 3, 2024

I merged up from main and once CI passes I think this will be good to go

@alamb alamb merged commit ecc1c01 into apache:main Jul 3, 2024
@dharanad dharanad deleted the register-sql-planners-constructor branch July 4, 2024 01:42
comphead pushed a commit to comphead/arrow-datafusion that referenced this pull request Jul 8, 2024
* Register SQL planners in SessionState constructor

* update map capacity with user_defined_sql_planners ref count

* formatting

* undo last

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
* Register SQL planners in SessionState constructor

* update map capacity with user_defined_sql_planners ref count

* formatting

* undo last

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Register SQL planners in SessionState::new()

2 participants