Refine ParquetAccessPlan comments and tests #10896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advancedxy
approved these changes
Jun 13, 2024
Contributor
advancedxy
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your quick update.
Dandandan
approved these changes
Jun 13, 2024
Contributor
Author
Thank you @advancedxy for taking the time to provide your comments. Thank you @Dandandan for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #10813
Rationale for this change
@advancedxy had some good suggestions in #10813 (review)
What changes are included in this PR?
Implement suggestions from #10813 (review)
Are these changes tested?
Existing CI
Are there any user-facing changes?
Not really -- there is a new debug log message