Minor: Extract parent/child limit calculation into a function, improve docs #10501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
May 14, 2024
| (None, None) => None, | ||
| }; | ||
| let (skip, fetch) = | ||
| combine_limit(limit.skip, limit.fetch, child.skip, child.fetch); |
Contributor
Author
There was a problem hiding this comment.
this PR just refactors all the existing logic to a function
This was referenced May 14, 2024
comphead
reviewed
May 15, 2024
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
Contributor
Author
|
Thanks for the review @comphead |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…e docs (apache#10501) * Minor: Extract parent/child limit calculation into a function, improve docs * Update datafusion/optimizer/src/push_down_limit.rs Co-authored-by: Oleks V <comphead@users.noreply.github.com> --------- Co-authored-by: Oleks V <comphead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #10292
Rationale for this change
While reviewing the code for
PushDownLimitthis logic is slightly tricky and a natural candidate to extract into a function to allow docstrings as well as to make the refactoring to avoid copies slightly easierWhat changes are included in this PR?
Are these changes tested?
Existing CI
Are there any user-facing changes?