fix: no longer support the substring function
#10242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
reviewed
Apr 26, 2024
Comment on lines
+1875
to
+1883
| query T | ||
| SELECT substring('alphabet', 1) | ||
| ---- | ||
| alphabet | ||
|
|
||
| query T | ||
| SELECT substring('alphabet', 3, 2) | ||
| ---- | ||
| ph |
Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
Jefffrey
approved these changes
Apr 26, 2024
Contributor
Jefffrey
left a comment
There was a problem hiding this comment.
Looks good, nice catch 👍
Contributor
appletreeisyellow
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Apr 26, 2024
* fix: no longer support the `substring` function * enable from-for format * update test comment * review feedback * review feedback Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com> --------- Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
appletreeisyellow
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Apr 30, 2024
* fix: no longer support the `substring` function * enable from-for format * update test comment * review feedback * review feedback Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com> --------- Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
appletreeisyellow
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Apr 30, 2024
* fix: no longer support the `substring` function * enable from-for format * update test comment * review feedback * review feedback Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com> --------- Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10240.
Rationale for this change
Before version 0.45.0 of sqlparser, the
specialflag for bothsubstring('xxxx', 1, 2)andsubstring('xxxx' from 1 for 2)was false.After apache/datafusion-sqlparser-rs#1173, the
specialflag forsubstring('xxxx', 1, 2)becomes true.We need to support both formats as before, so there's no need to check the
specialflag.The 'from' and 'for' parameters don't support string types because they should be treated as regular expressions. Currently, substring is just an alias of
substr. This PR adds tests to verify this.Reference document: https://www.postgresql.org/docs/current/functions-string.html
What changes are included in this PR?
Re-enable
substring('xxxx', 1, 2).Are these changes tested?
Yes
Are there any user-facing changes?
No