Skip to content

Migrate tests to JUnit5 - final#359

Merged
garydgregory merged 2 commits intoapache:masterfrom
jkbkupczyk:junit5_migration_v2
Aug 12, 2025
Merged

Migrate tests to JUnit5 - final#359
garydgregory merged 2 commits intoapache:masterfrom
jkbkupczyk:junit5_migration_v2

Conversation

@jkbkupczyk
Copy link
Copy Markdown
Contributor

@jkbkupczyk jkbkupczyk commented Aug 12, 2025

This PR is a follow-up to #358, it finalizes the migration of tests to JUnit5 within project.

@garydgregory
Copy link
Copy Markdown
Member

Hello @jkbkupczyk

Thank you for completing this task.
Don't forget to drop the vintage JUnit JAR 😉

commons-net/pom.xml

Lines 112 to 116 in cf048de

<dependency>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<scope>test</scope>
</dependency>

@jkbkupczyk
Copy link
Copy Markdown
Contributor Author

Hello @jkbkupczyk

Thank you for completing this task. Don't forget to drop the vintage JUnit JAR 😉

commons-net/pom.xml

Lines 112 to 116 in cf048de

<dependency>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<scope>test</scope>
</dependency>

OFC, as soon I finish the work on ListingFunctionalTest. Thanks for pointing that out ;)

@jkbkupczyk jkbkupczyk changed the title WIP: Migrate tests to JUnit5 - final Migrate tests to JUnit5 - final Aug 12, 2025
@jkbkupczyk jkbkupczyk marked this pull request as ready for review August 12, 2025 20:46
@jkbkupczyk
Copy link
Copy Markdown
Contributor Author

@garydgregory done, please take a look. All tests are finally running with JUnit5! Now we are waiting for JUnit6 😃

@garydgregory
Copy link
Copy Markdown
Member

Just dropping a note here that the unit test count is the same as master:

Tests run: 557, Failures: 0, Errors: 0, Skipped: 2

@garydgregory garydgregory merged commit e479c32 into apache:master Aug 12, 2025
11 checks passed
garydgregory added a commit that referenced this pull request Aug 12, 2025
@garydgregory
Copy link
Copy Markdown
Member

@jkbkupczyk
Thank you so much! 👍👌

@jkbkupczyk
Copy link
Copy Markdown
Contributor Author

@jkbkupczyk Thank you so much! 👍👌

TY for review! Do you know of any other commons-* projects that might require a JUnit5 migration?

@garydgregory
Copy link
Copy Markdown
Member

@jkbkupczyk Thank you so much! 👍👌

TY for review! Do you know of any other commons-* projects that might require a JUnit5 migration?

@jkbkupczyk
Commons VFS still has bits stuck on JUnit 3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants