Unit tests and coverage for binary operations#174
Merged
garydgregory merged 8 commits intoapache:masterfrom Nov 27, 2022
Merged
Unit tests and coverage for binary operations#174garydgregory merged 8 commits intoapache:masterfrom
garydgregory merged 8 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
============================================
+ Coverage 60.59% 60.83% +0.24%
- Complexity 3577 3616 +39
============================================
Files 363 363
Lines 15630 15630
Branches 1943 1943
============================================
+ Hits 9471 9509 +38
+ Misses 5288 5248 -40
- Partials 871 873 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
VerifyError here https://github.com/nbauma109/commons-bcel/actions/runs/3553873697/jobs/5969635608 fixed manually on BinaryOpCreator nbauma109@f6e1627#diff-2e9bc4b884d759888c4a070c4cdb3954ae7b8462a1b4ba88db738994b1a5bc9bR587-R593 I'll submit a separate PR to generate this code. |
asfgit
pushed a commit
that referenced
this pull request
Nov 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a unit test to cover binary operations.
However, the class produced by
BinaryOpCreatordoesn't pass the verfier from the JDK (not speaking about the JustIce one).It runs only with
-noverifyoption. As this option is deprecated in JDK13+, I disabled the unit test for JDK13+.I think we need to fix this broken class generator later.