Skip to content

kvm: fix ovs network creation issue#9869

Merged
yadvr merged 1 commit intoapache:4.19from
weizhouapache:4.19-kvm-fix-ovs-regression
Nov 7, 2024
Merged

kvm: fix ovs network creation issue#9869
yadvr merged 1 commit intoapache:4.19from
weizhouapache:4.19-kvm-fix-ovs-regression

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Oct 29, 2024

Description

This PR fixes the issue below when create a ovs network

2024-10-29 16:02:45,089 WARN  [resource.wrapper.LibvirtOvsFetchInterfaceCommandWrapper] (agentRequest-Handler-2:null) (logid:e716722e) Network interface: ''cloudbr1'' not found

This is a regression of a previous security release
see "framework/cluster: improve cluster service, integration API server"

since we now use NetworkInterface.getByName to get network interface, we should NOT add single quotes before/after the label.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
kvm: fix ovs network creation issue
6a7255b 
This fixes the issue when create a ovs network
```
2024-10-29 16:02:45,089 WARN  [resource.wrapper.LibvirtOvsFetchInterfaceCommandWrapper] (agentRequest-Handler-2:null) (logid:e716722e) Network interface: ''cloudbr1'' not found
```

This is a regression of a previous security release
see "framework/cluster: improve cluster service, integration API server"

since we now use NetworkInterface.getByName to get network interface, we should NOT add single quotes before/after the label.
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.08%. Comparing base (175eed2) to head (6a7255b).
Report is 3 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #9869      +/-   ##
============================================
- Coverage     15.08%   15.08%   -0.01%     
  Complexity    11203    11203              
============================================
  Files          5404     5404              
  Lines        473423   473423              
  Branches      59987    59246     -741     
============================================
- Hits          71429    71428       -1     
- Misses       394044   394046       +2     
+ Partials       7950     7949       -1
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.80% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Oct 29, 2024

the OVS functionality is broken in the following releases

  • 4.18.2.1
  • 4.18.2.2
  • 4.18.2.3
  • 4.18.2.4
  • 4.19.1.0
  • 4.19.1.1
  • 4.19.1.2

marked it as a BLOCKER

cc @rohityadavcloud @DaanHoogland @borisstoyanov @GutoVeronezi

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Oct 29, 2024

cc @rajujith

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Oct 29, 2024

@blueorangutan package

1 similar comment
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Oct 29, 2024

@blueorangutan package

sureshanaparti
sureshanaparti approved these changes Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@yadvr yadvr modified the milestones: 4.20.1.0, 4.20.0.0 Oct 30, 2024
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Oct 31, 2024

@blueorangutan LLpackage

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 31, 2024

@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 31, 2024

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 6214

@DaanHoogland DaanHoogland modified the milestones: 4.20.0.0, 4.19.2.0 Oct 31, 2024
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Oct 31, 2024

@blueorangutan LLtest ubuntu22 kvm-ubuntu22

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 31, 2024

@weizhouapache a [LL] Trillian-Jenkins test job (ubuntu22 mgmt + kvm-ubuntu22) has been kicked to run smoke tests

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Oct 31, 2024

@blueorangutan LLtest alma8 kvm-alma8

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 31, 2024

@weizhouapache a [LL] Trillian-Jenkins test job (alma8 mgmt + kvm-alma8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 1, 2024

[LL]Trillian test result (tid-7040)
Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8
Total time taken: 47709 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9869-t7040-kvm-alma8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_unsecure_vm_migration Error 394.85 test_vm_life_cycle.py
test_02_unsecure_vm_migration Error 394.86 test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration Error 0.01 test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration Error 0.01 test_vm_life_cycle.py

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 1, 2024

[LL]Trillian test result (tid-7038)
Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8
Total time taken: 52327 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9869-t7038-kvm-alma8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_secure_vm_migration Error 244.21 test_vm_life_cycle.py

@weizhouapache weizhouapache marked this pull request as ready for review November 6, 2024 09:28
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Nov 6, 2024

tested on centos7 and ubuntu 24 with OVS, looks good

cc @rohityadavcloud @DaanHoogland @GutoVeronezi

shwstppr
shwstppr approved these changes Nov 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr merged commit 006db90 into apache:4.19 Nov 7, 2024
@DaanHoogland DaanHoogland deleted the 4.19-kvm-fix-ovs-regression branch November 7, 2024 09:07
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 20, 2024
@weizhouapache @dhslove
kvm: fix ovs network creation issue (apache#9869)
2b19317 
This fixes the issue when create a ovs network
```
2024-10-29 16:02:45,089 WARN  [resource.wrapper.LibvirtOvsFetchInterfaceCommandWrapper] (agentRequest-Handler-2:null) (logid:e716722e) Network interface: ''cloudbr1'' not found
```

This is a regression of a previous security release
see "framework/cluster: improve cluster service, integration API server"

since we now use NetworkInterface.getByName to get network interface, we should NOT add single quotes before/after the label.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@JoaoJandre JoaoJandre JoaoJandre approved these changes

@GutoVeronezi GutoVeronezi Awaiting requested review from GutoVeronezi

Assignees

No one assigned

Labels

component:kvm Severity:BLOCKER

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

7 participants

@weizhouapache @blueorangutan @yadvr @shwstppr @DaanHoogland @sureshanaparti @JoaoJandre