list hosts API fix, when any stale entries exists on storage_pool_host_ref for the removed pools by sureshanaparti · Pull Request #9852 · apache/cloudstack

sureshanaparti · 2024-10-24T12:11:35Z

Description

The list hosts API fails with NPE, when any stale entries exists on storage_pool_host_ref for the removed pools. This PR fixes it.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Manually verified the fix, with entry on storage_pool_host_ref for removed pool.

How did you try to break this feature and the system with this change?

…host_ref for the removed pools

sureshanaparti · 2024-10-24T12:12:20Z

@blueorangutan package

blueorangutan · 2024-10-24T12:14:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-10-24T12:19:23Z

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 15.08%. Comparing base (175eed2) to head (defb879).
Report is 88 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/storage/StorageManagerImpl.java	0.00%	8 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9852      +/-   ##
============================================
- Coverage     15.08%   15.08%   -0.01%     
+ Complexity    11203    11200       -3     
============================================
  Files          5404     5404              
  Lines        473423   473423              
  Branches      59987    60194     +207     
============================================
- Hits          71429    71426       -3     
- Misses       394044   394048       +4     
+ Partials       7950     7949       -1

Flag	Coverage Δ
uitests	`4.30% <ø> (ø)`
unittests	`15.80% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-10-24T12:50:10Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 11429

sureshanaparti · 2024-10-24T13:50:10Z

@blueorangutan package

blueorangutan · 2024-10-24T13:52:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-10-24T14:45:28Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11430

sureshanaparti · 2024-10-24T19:39:19Z

@blueorangutan test

blueorangutan · 2024-10-24T19:40:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-10-25T08:30:28Z

[SF] Trillian test result (tid-11699)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 44007 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9852-t11699-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	`Error`	134.44	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	134.45	test_vm_life_cycle.py

DaanHoogland

clgtm

server/src/main/java/com/cloud/storage/StorageManagerImpl.java

sureshanaparti · 2024-10-30T12:13:49Z

@blueorangutan package

sureshanaparti · 2024-10-30T12:20:59Z

@blueorangutan package

yadvr · 2024-11-07T09:11:58Z

@blueorangutan test

DaanHoogland · 2024-11-07T14:21:01Z

@blueorangutan package

blueorangutan · 2024-11-07T14:22:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-11-07T15:24:50Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11526

DaanHoogland · 2024-11-07T15:49:08Z

@blueorangutan test

blueorangutan · 2024-11-07T15:50:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-11-08T06:40:19Z

[SF] Trillian test result (tid-11766)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51079 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9852-t11766-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	`Error`	133.47	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	133.47	test_vm_life_cycle.py

vishesh92

clgtm. didn't test.

DaanHoogland · 2025-01-29T16:08:29Z

@blueorangutan test keepEnv

blueorangutan · 2025-01-29T16:10:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-01-30T05:46:49Z

[SF] Trillian test result (tid-12230)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46489 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9852-t12230-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	`Error`	135.51	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	135.51	test_vm_life_cycle.py

DaanHoogland · 2025-01-30T08:16:39Z

tested by removing a primary store and re-inserting one of the storage_pool_host_ref entries for it. listing went on fine from cmk.

…t_ref for the removed pools (apache#9852)

Fix NPE on list hosts, when any stale entries exists on storage_pool_…

637077e

…host_ref for the removed pools

boring-cyborg bot added the component:storage label Oct 24, 2024

sureshanaparti added this to the 4.19.2.0 milestone Oct 24, 2024

sureshanaparti requested review from DaanHoogland and vishesh92 October 25, 2024 08:32

DaanHoogland approved these changes Oct 28, 2024

View reviewed changes

slavkap reviewed Oct 30, 2024

View reviewed changes

server/src/main/java/com/cloud/storage/StorageManagerImpl.java Outdated Show resolved Hide resolved

slavkap approved these changes Oct 30, 2024

View reviewed changes

review comments

defb879

apache deleted a comment from blueorangutan Nov 8, 2024

DaanHoogland added the type:bug label Nov 12, 2024

DaanHoogland assigned vladimirpetrov Nov 12, 2024

DaanHoogland added the status:needs-testing label Nov 12, 2024

vishesh92 approved these changes Nov 27, 2024

View reviewed changes

vladimirpetrov removed their assignment Dec 11, 2024

DaanHoogland self-assigned this Jan 30, 2025

DaanHoogland added status:ready-for-merge and removed status:needs-testing labels Jan 30, 2025

DaanHoogland merged commit ee0dc5b into apache:4.19 Jan 30, 2025

DaanHoogland deleted the listhosts-npe-issue branch January 30, 2025 14:34

rg9975 pushed a commit to rg9975/cloudstack that referenced this pull request Jan 31, 2025

list hosts API fix, when any stale entries exists on storage_pool_hos…

556c9dd

…t_ref for the removed pools (apache#9852)

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025

list hosts API fix, when any stale entries exists on storage_pool_hos…

1ac10fe

…t_ref for the removed pools (apache#9852)

DaanHoogland mentioned this pull request Sep 16, 2025

[router] make a distinction between fatal errors, warnings and unknown as healthcheck result #10710

Merged

14 tasks

DaanHoogland removed their assignment Dec 24, 2025

Conversation

sureshanaparti commented Oct 24, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Oct 24, 2024

Uh oh!

blueorangutan commented Oct 24, 2024

Uh oh!

codecov bot commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Oct 24, 2024

Uh oh!

sureshanaparti commented Oct 24, 2024

Uh oh!

blueorangutan commented Oct 24, 2024

Uh oh!

blueorangutan commented Oct 24, 2024

Uh oh!

sureshanaparti commented Oct 24, 2024

Uh oh!

blueorangutan commented Oct 24, 2024

Uh oh!

blueorangutan commented Oct 25, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sureshanaparti commented Oct 30, 2024

Uh oh!

sureshanaparti commented Oct 30, 2024

Uh oh!

yadvr commented Nov 7, 2024

Uh oh!

DaanHoogland commented Nov 7, 2024

Uh oh!

blueorangutan commented Nov 7, 2024

Uh oh!

blueorangutan commented Nov 7, 2024

Uh oh!

DaanHoogland commented Nov 7, 2024

Uh oh!

blueorangutan commented Nov 7, 2024

Uh oh!

blueorangutan commented Nov 8, 2024

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jan 29, 2025

Uh oh!

blueorangutan commented Jan 29, 2025

Uh oh!

blueorangutan commented Jan 30, 2025

Uh oh!

DaanHoogland commented Jan 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov bot commented Oct 24, 2024 •

edited

Loading