StorPool: support for direct download#9833
Conversation
Added support to directly download templates on StorPool
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9833 +/- ##
============================================
- Coverage 15.78% 15.78% -0.01%
Complexity 12564 12564
============================================
Files 5627 5627
Lines 492250 492374 +124
Branches 61405 62914 +1509
============================================
- Hits 77710 77709 -1
- Misses 406066 406191 +125
Partials 8474 8474
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| public static boolean attachOrDetachVolume(String command, String type, String volumeUuid) { | ||
| if (volumeUuid == null) { |
There was a problem hiding this comment.
command can be attach and detach only, right? can use bool instead of string, or for define any enum for operation and use that.
There was a problem hiding this comment.
@sureshanaparti, yes, there is an option for boolean/enum, but this method is used almost everywhere in the StorPool plug-in (agent's part). I don't think this PR is the place for refactoring
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13626 |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13719 |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13737 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-13513)
|
Description
Added support to download templates on StorPool directly
Types of changes
Feature/Enhancement Scale
How Has This Been Tested?
Manually tested