Skip to content

VR: fix wrong check when compare two configuration files#9822

Merged
yadvr merged 1 commit intoapache:4.18from
weizhouapache:4.18-vr-file-compare
Nov 7, 2024
Merged

VR: fix wrong check when compare two configuration files#9822
yadvr merged 1 commit intoapache:4.18from
weizhouapache:4.18-vr-file-compare

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Oct 17, 2024

Description

in some configuration files, the value can be set in multiple times and order matters.
For example there are two haproxy configurations

listen 10_0_xx_yy-22
	bind 10.0.xx.yy:22
	balance roundrobin

listen 10_0_xx_yy-23
	bind 10.0.xx.yy:23
	balance source

listen 10_0_xx_yy-22
	bind 10.0.xx.yy:22
	balance source

listen 10_0_xx_yy-23
	bind 10.0.xx.yy:23
	balance roundrobin

without this change, they are considered as same configuration, which is obviously wrong.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache linked an issue Oct 17, 2024 that may be closed by this pull request
Autoscale Source Based Sticky Session Doesnt Always Work #9583
Closed
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Oct 17, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 17, 2024

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache weizhouapache added this to the 4.19.2.0 milestone Oct 17, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.27%. Comparing base (1af4158) to head (cbfa59d).
Report is 2 commits behind head on 4.18.

Additional details and impacted files 
@@             Coverage Diff             @@
##               4.18    #9822     +/-   ##
===========================================
  Coverage     12.27%   12.27%             
- Complexity     9335     9336      +1     
===========================================
  Files          4699     4699             
  Lines        414691   414691             
  Branches      53409    51957   -1452     
===========================================
+ Hits          50891    50896      +5     
+ Misses       357475   357469      -6     
- Partials       6325     6326      +1
Flag Coverage Δ
unittests 12.27% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 17, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11380

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Oct 17, 2024

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 17, 2024

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 18, 2024

[SF] Trillian test result (tid-11683)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45826 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9822-t11683-kvm-ol8.zip
Smoke tests completed. 110 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestISOUsage>:setup Error 0.00 test_usage.py

@weizhouapache weizhouapache marked this pull request as ready for review October 18, 2024 09:24
DaanHoogland
DaanHoogland reviewed Oct 28, 2024
View reviewed changes
@yadvr yadvr merged commit 896b8bf into apache:4.18 Nov 7, 2024
@DaanHoogland DaanHoogland deleted the 4.18-vr-file-compare branch November 7, 2024 10:26
@DaanHoogland DaanHoogland mentioned this pull request Nov 8, 2024
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 20, 2024
@weizhouapache @dhslove
VR: fix wrong check when compare two configuration files (apache#9822)
29a2ad3
@weizhouapache weizhouapache mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees

No one assigned

Labels

component:networking component:virtual-router Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

Autoscale Source Based Sticky Session Doesnt Always Work

5 participants

@weizhouapache @blueorangutan @yadvr @DaanHoogland @sureshanaparti