Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9798 +/- ##
============================================
- Coverage 15.80% 15.08% -0.72%
- Complexity 11199 11200 +1
============================================
Files 5038 5404 +366
Lines 443875 473417 +29542
Branches 52607 58747 +6140
============================================
+ Hits 70139 71416 +1277
- Misses 365934 394054 +28120
- Partials 7802 7947 +145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yadvr
approved these changes
Oct 16, 2024
vishesh92
approved these changes
Oct 16, 2024
Member
vishesh92
left a comment
There was a problem hiding this comment.
clgtm. And the UI build is successful.
Member
|
cc @JoaoJandre fwd-merging this build/UI failure on main |
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Oct 24, 2024
weizhouapache
added a commit
to weizhouapache/cloudstack
that referenced
this pull request
Nov 6, 2024
* Session Token Invalidation on Logout * fix quota resource access validation * Validate QCOW2 on upload and register * util: check JSESSIONID in cookies if user is passed * Fix Vue devServer after CSRF fix * UI: fix unit tests (apache#9798) (cherry picked from commit 9661060) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> --------- Co-authored-by: Daan Hoogland <daan@onecht.net> Co-authored-by: Daniel Augusto Veronezi Salvador <gutoveronezi@apache.org> Co-authored-by: Wei Zhou <weizhou@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the UI unit test failures
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?