Skip to content

API: Fix listing Userdata by keyword or name#9751

Merged
DaanHoogland merged 1 commit into4.19from
fix-list-userdata
Oct 2, 2024
Merged

API: Fix listing Userdata by keyword or name#9751
DaanHoogland merged 1 commit into4.19from
fix-list-userdata

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 commented Sep 30, 2024

Description

This PR fixes #9686

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.08%. Comparing base (0208e09) to head (5355d56).
Report is 352 commits behind head on 4.19.

❗ There is a different number of reports uploaded between BASE (0208e09) and HEAD (5355d56). Click for more details.

HEAD has 18 uploads less than BASE
Flag BASE (0208e09) HEAD (5355d56)
simulator-marvin-tests 17 0
unit-tests 1 0
Additional details and impacted files 
@@              Coverage Diff              @@
##               4.19    #9751       +/-   ##
=============================================
- Coverage     30.91%   15.08%   -15.83%     
+ Complexity    34249    11187    -23062     
=============================================
  Files          5354     5402       +48     
  Lines        376094   473137    +97043     
  Branches      54696    61618     +6922     
=============================================
- Hits         116258    71379    -44879     
- Misses       244542   393816   +149274     
+ Partials      15294     7942     -7352
Flag Coverage Δ
simulator-marvin-tests ?
uitests 4.30% <ø> (-0.10%) ⬇️
unit-tests ?
unittests 15.80% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DaanHoogland
DaanHoogland approved these changes Oct 1, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Oct 1, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 1, 2024

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 1, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11250

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Oct 1, 2024

@blueorangutan test keepEnv

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 1, 2024

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@yadvr yadvr added this to the 4.19.2.0 milestone Oct 1, 2024
sureshanaparti
sureshanaparti approved these changes Oct 1, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 2, 2024

[SF] Trillian test result (tid-11586)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 43620 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9751-t11586-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_ping_in_ssvm_success Failure 14.51 test_diagnostics.py

@DaanHoogland DaanHoogland self-requested a review October 2, 2024 07:02
DaanHoogland
DaanHoogland requested changes Oct 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, but testing doesn't yield good results. need to look further

@DaanHoogland DaanHoogland self-requested a review October 2, 2024 13:24
@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Oct 2, 2024

code looks good, but testing doesn't yield good results. need to look further

seems to have been me :( test ok :)

@DaanHoogland DaanHoogland merged commit 2e4dd69 into 4.19 Oct 2, 2024
@DaanHoogland DaanHoogland deleted the fix-list-userdata branch October 2, 2024 13:25
@weizhouapache weizhouapache mentioned this pull request Oct 10, 2024
Closed
@weizhouapache weizhouapache linked an issue Oct 10, 2024 that may be closed by this pull request
List userdata with name or keyword not list anything #9686
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 14, 2024
@Pearl1594 @dhslove
API: Fix listing Userdata by keyword or name (apache#9751)
0085e61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

Assignees

No one assigned

Labels

component:management-server

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

List userdata with name or keyword not list anything

5 participants

@Pearl1594 @DaanHoogland @blueorangutan @yadvr @sureshanaparti