Skip to content

Fix ISO url in test_usage.py#9739

Merged
weizhouapache merged 1 commit intoapache:4.19from
weizhouapache:4.19-fix-dummy-iso-url
Sep 28, 2024
Merged

Fix ISO url in test_usage.py#9739
weizhouapache merged 1 commit intoapache:4.19from
weizhouapache:4.19-fix-dummy-iso-url

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Sep 27, 2024

Description

This PR fixes the test failure with test_usage.py

the site people.apache.org has been deprecated.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Sep 27, 2024
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 27, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 27, 2024

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.08%. Comparing base (cb4713f) to head (aaca1a8).
Report is 1 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #9739      +/-   ##
============================================
- Coverage     15.11%   15.08%   -0.03%     
- Complexity    11184    11185       +1     
============================================
  Files          5402     5402              
  Lines        473137   473137              
  Branches      58578    58002     -576     
============================================
- Hits          71508    71370     -138     
  Misses       393828   393828              
- Partials       7801     7939     +138
Flag Coverage Δ
uitests 4.30% <ø> (-0.47%) ⬇️
unittests 15.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sureshanaparti
sureshanaparti approved these changes Sep 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified Url, LGTM

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 27, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11219

DaanHoogland
DaanHoogland approved these changes Sep 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Sep 27, 2024

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 27, 2024

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 28, 2024

[SF] Trillian test result (tid-11566)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45160 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9739-t11566-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache weizhouapache merged commit 67ce326 into apache:4.19 Sep 28, 2024
@DaanHoogland DaanHoogland deleted the 4.19-fix-dummy-iso-url branch September 28, 2024 08:45
DaanHoogland added a commit that referenced this pull request Sep 30, 2024
@DaanHoogland
Merge release branch 4.19 to main
2fa1761 
* 4.19:
  Fix ISO url in test_usage.py (#9739)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 14, 2024
@weizhouapache @dhslove
Fix ISO url in test_usage.py (apache#9739)
ede0559
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 14, 2024
@DaanHoogland @dhslove
Merge release branch 4.19 to main
59e0a98 
* 4.19:
  Fix ISO url in test_usage.py (apache#9739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees

No one assigned

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@weizhouapache @blueorangutan @DaanHoogland @sureshanaparti