Hide UserData field from the EditVM view for VMs that do not offer it#9731
Conversation
…serdata if the vm's network does not offer the feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9731 +/- ##
============================================
- Coverage 15.11% 15.08% -0.03%
Complexity 11184 11184
============================================
Files 5402 5402
Lines 473120 473147 +27
Branches 58327 59210 +883
============================================
- Hits 71507 71370 -137
- Misses 393812 393838 +26
- Partials 7801 7939 +138
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
kiranchavala
left a comment
There was a problem hiding this comment.
LGTM
Before fix
The edit vm action had the userdata text box even if the network offering didn't support userdata
--
After fix
There is no userdata box when user clicks on edit vm if the network offering didn't support userdata
… and listVirtualMachines
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Merging based on approvals and manual test by @kiranchavala (#9731 (review)) |
…apache#9731) * added a v-if directive within the EditVm view to not show the field userdata if the vm's network does not offer the feature * added the parameter listall:true to the requests made to listNetworks and listVirtualMachines
Description
Currently in ACS, when editing a VM, the field userdata will be present even if the VM's network does not support the feature. This PR fixes this issue by not showing the field if the VM does not offer userdata.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
I tested this by verifying if the userdata field would still show up in the Edit VM View when editing VMs whose networks did not offer userdata, and it worked as expected. I've also tested cases in which a VM could have more than one network, and for these cases it will consider the default network and disregard the other networks.