Skip to content

UI: enable project menu on mobile devices#9700

Merged
yadvr merged 1 commit intoapache:4.19from
weizhouapache:4.19-ui-show-project-on-mobile
Sep 19, 2024
Merged

UI: enable project menu on mobile devices#9700
yadvr merged 1 commit intoapache:4.19from
weizhouapache:4.19-ui-show-project-on-mobile

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Sep 18, 2024 •
edited
Loading

Description

This PR shows project menu on mobile devices

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.11%. Comparing base (a8ab47b) to head (298dbb3).
Report is 6 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff             @@
##               4.19    #9700     +/-   ##
===========================================
  Coverage     15.11%   15.11%             
+ Complexity    11189    11187      -2     
===========================================
  Files          5406     5406             
  Lines        473215   473215             
  Branches      61384    59430   -1954     
===========================================
+ Hits          71516    71528     +12     
+ Misses       393891   393883      -8     
+ Partials       7808     7804      -4
Flag Coverage Δ
uitests 4.76% <ø> (ø)
unittests 15.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Sep 18, 2024

@weizhouapache have you tested this/ is it draft? I wonder why this was put in place. Is the reason for that gone?

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 18, 2024

@weizhouapache have you tested this/ is it draft? I wonder why this was put in place. Is the reason for that gone?

@DaanHoogland
to be frank, I have no idea.
it was introduced in a very early commit 63e6173 by @rohityadavcloud

I used Chrome for testing

  • an env without this PR

image

  • an env with this change

image

@weizhouapache weizhouapache changed the title UI: enable project menu on mobile UI: enable project menu on mobile devices Sep 18, 2024
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 18, 2024

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 18, 2024

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Sep 18, 2024

ok, will test on ff

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 18, 2024

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9700 (QA-JID-451)

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Sep 18, 2024

ok, will test on ff

Screenshot_20240918-104930

works 👍

FelipeM525
FelipeM525 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@FelipeM525 FelipeM525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested in the simulator build!

@yadvr yadvr added this to the 4.19.2.0 milestone Sep 19, 2024
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 19, 2024

Sorry mea culpa - I think it 'could' break on some screens; but LGTM.

@yadvr yadvr merged commit 50d7ebf into apache:4.19 Sep 19, 2024
@DaanHoogland DaanHoogland deleted the 4.19-ui-show-project-on-mobile branch September 19, 2024 12:32
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 23, 2024
@weizhouapache @dhslove
UI: enable project menu on mobile (apache#9700)
1c01321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

+1 more reviewer

@FelipeM525 FelipeM525 FelipeM525 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

5 participants

@weizhouapache @DaanHoogland @blueorangutan @yadvr @FelipeM525