Skip to content

lb: fix haproxy cannot start if algorithm is not lowercase#9698

Merged
yadvr merged 1 commit intoapache:4.19from
weizhouapache:4.19-fix-lb-algorithm-uppercase
Sep 19, 2024
Merged

lb: fix haproxy cannot start if algorithm is not lowercase#9698
yadvr merged 1 commit intoapache:4.19from
weizhouapache:4.19-fix-lb-algorithm-uppercase

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Sep 18, 2024

Description

This PR fixes an issue reproduced by steps below

  • create a LB with algorithm=Source (not source)
  • add a vm to the lb
  • check cloudstack VR, haproxy fails
Sep 18 06:52:12 r-721-VM haproxy[2042]: [NOTICE]   (2042) : haproxy version is 2.6.12-1+deb12u1
Sep 18 06:52:12 r-721-VM haproxy[2042]: [NOTICE]   (2042) : path to executable is /usr/sbin/haproxy
Sep 18 06:52:12 r-721-VM haproxy[2042]: [WARNING]  (2042) : config : 'stats' statement ignored for proxy 'cloud-default' as it requires HTTP mode.
Sep 18 06:52:12 r-721-VM haproxy[2042]: [WARNING]  (2042) : config : 'option forwardfor' ignored for proxy 'cloud-default' as it requires HTTP mode.
Sep 18 06:52:12 r-721-VM haproxy[2042]: [NOTICE]   (2042) : New worker (2069) forked
Sep 18 06:52:12 r-721-VM haproxy[2042]: [NOTICE]   (2042) : Loading success.
Sep 18 06:52:12 r-721-VM systemd[1]: Started haproxy.service - HAProxy Load Balancer.
Sep 18 07:32:46 r-721-VM systemd[1]: Reloading haproxy.service - HAProxy Load Balancer...
Sep 18 07:32:46 r-721-VM systemd[1]: haproxy.service: Control process exited, code=exited, status=1/FAILURE
Sep 18 07:32:46 r-721-VM systemd[1]: Reload failed for haproxy.service - HAProxy Load Balancer.
  • the issue can be manually fixed by
# root@r-721-VM:~# sed -i "s/balance Source/balance source/g" /etc/haproxy/haproxy.cfg
# systemctl reload haproxy

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.11%. Comparing base (a8ab47b) to head (4487bde).
Report is 7 commits behind head on 4.19.

Additional details and impacted files 
@@            Coverage Diff             @@
##               4.19    #9698    +/-   ##
==========================================
  Coverage     15.11%   15.11%            
- Complexity    11189    11193     +4     
==========================================
  Files          5406     5406            
  Lines        473215   473215            
  Branches      61384    61155   -229     
==========================================
+ Hits          71516    71527    +11     
+ Misses       393891   393878    -13     
- Partials       7808     7810     +2
Flag Coverage Δ
uitests 4.76% <ø> (ø)
unittests 15.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DaanHoogland
DaanHoogland approved these changes Sep 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 18, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 18, 2024

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 18, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11139

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 18, 2024

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 18, 2024

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 18, 2024

[SF] Trillian test result (tid-11508)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 44695 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9698-t11508-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@yadvr yadvr added this to the 4.19.2.0 milestone Sep 19, 2024
@yadvr yadvr merged commit 7f2ab63 into apache:4.19 Sep 19, 2024
@DaanHoogland DaanHoogland deleted the 4.19-fix-lb-algorithm-uppercase branch September 19, 2024 12:31
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 23, 2024
@weizhouapache @dhslove
lb: fix haproxy cannot start if algorithm is not lowercase (apache#9698)
9e0a3f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

4 participants

@weizhouapache @blueorangutan @yadvr @DaanHoogland