UI: Fix starting VMs through group action by non-root-admin users#9652
Merged
DaanHoogland merged 1 commit intoapache:4.19from Sep 9, 2024
Merged
Conversation
Member
Author
|
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9652 +/- ##
============================================
- Coverage 15.08% 15.08% -0.01%
+ Complexity 11192 11189 -3
============================================
Files 5406 5406
Lines 473183 473186 +3
Branches 61397 57683 -3714
============================================
- Hits 71390 71375 -15
- Misses 393844 393864 +20
+ Partials 7949 7947 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
yadvr
approved these changes
Sep 9, 2024
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When non-root-admin users try to start multiple virtual machines, the form does not provide options to cancel or confirm the operation.
This PR fixes this bug.
Fixes #9651
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
Before
After
How Has This Been Tested?
Consider Last Hostfield was rendered correctly.