Skip to content

Fixed Unable to create a domain when networkdomain is mentioned and cleared#9637

Merged
DaanHoogland merged 1 commit intoapache:4.19from
FelipeM525:fix-create-domain-form
Sep 20, 2024
Merged

Fixed Unable to create a domain when networkdomain is mentioned and cleared#9637
DaanHoogland merged 1 commit intoapache:4.19from
FelipeM525:fix-create-domain-form

Conversation

@FelipeM525
Copy link
Copy Markdown
Contributor

@FelipeM525 FelipeM525 commented Sep 4, 2024 •
edited by DaanHoogland
Loading

Description

This PR fixes #9623

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

I tested this PR by typing inside the networkdomain field in the Add domain form and then clearing it, which ended up working as expected after the proposed changes.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.57%. Comparing base (5ff0b99) to head (45bfd41).

Additional details and impacted files 
@@             Coverage Diff             @@
##               main    #9637     +/-   ##
===========================================
  Coverage     15.57%   15.57%             
  Complexity    12052    12052             
===========================================
  Files          5505     5505             
  Lines        482738   482741      +3     
  Branches      58961    60951   +1990     
===========================================
+ Hits          75203    75204      +1     
- Misses       399226   399229      +3     
+ Partials       8309     8308      -1
Flag Coverage Δ
uitests 4.17% <ø> (-0.01%) ⬇️
unittests 16.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yadvr
yadvr approved these changes Sep 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test, lgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Sep 5, 2024

loks good @FelipeM525 , can you base of the 4.19 branch?

@FelipeM525
fixed an issue where requests to the api createDomain were being sent…
b7366ac 
… with the field networkdomain as an empty string whenever the user typed something in the form and cleared it causing an exception
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 5, 2024

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@FelipeM525 FelipeM525 changed the base branch from main to 4.19 September 5, 2024 17:21
@kiranchavala
Copy link
Copy Markdown
Member

kiranchavala commented Sep 20, 2024

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 20, 2024

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 20, 2024

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9637 (QA-JID-455)

kiranchavala
kiranchavala approved these changes Sep 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Tested the fix manually and able to create domain if the network domain entered and cleared

@DaanHoogland DaanHoogland merged commit ee1cd91 into apache:4.19 Sep 20, 2024
@DaanHoogland DaanHoogland mentioned this pull request Oct 2, 2024
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 14, 2024
@FelipeM525 @dhslove
fixed an issue where requests to the api createDomain were being sent…
b6d64fc 
… with the field networkdomain as an empty string whenever the user typed something in the form and cleared it causing an exception (apache#9637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@kiranchavala kiranchavala kiranchavala approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:storage component:UI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UI: Unable to create a domain when networkdomain is mentioned and cleared

5 participants

@FelipeM525 @DaanHoogland @kiranchavala @blueorangutan @yadvr