Skip to content

Fix resource count discrepancy while associating IP address to a network#9563

Merged
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:fixup-public-ip-resource-count
Sep 19, 2024
Merged

Fix resource count discrepancy while associating IP address to a network#9563
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:fixup-public-ip-resource-count

Conversation

@vishesh92
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 commented Aug 21, 2024

Description

This PR fixes #9464

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 15.08%. Comparing base (1a403f1) to head (09f5680).
Report is 32 commits behind head on 4.19.

Files with missing lines Patch % Lines
...n/java/com/cloud/network/IpAddressManagerImpl.java 0.00% 9 Missing ⚠️
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               4.19    #9563    +/-   ##
==========================================
  Coverage     15.08%   15.08%            
  Complexity    11181    11181            
==========================================
  Files          5406     5406            
  Lines        472915   472924     +9     
  Branches      58400    57903   -497     
==========================================
+ Hits          71336    71341     +5     
- Misses       393637   393641     +4     
  Partials       7942     7942
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.80% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishesh92
Copy link
Copy Markdown
Member Author

vishesh92 commented Aug 21, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 21, 2024

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 21, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10731

@vishesh92
Copy link
Copy Markdown
Member Author

vishesh92 commented Aug 22, 2024

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 22, 2024

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sureshanaparti
sureshanaparti approved these changes Aug 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Aug 22, 2024

@vishesh92 linked issue targeted for 4.19.2, can rebase this with 4.19 branch?

@vishesh92 vishesh92 force-pushed the fixup-public-ip-resource-count branch from d978827 to 5f17fcd Compare August 22, 2024 11:06
@vishesh92 vishesh92 changed the base branch from main to 4.19 August 22, 2024 11:06
@vishesh92 vishesh92 force-pushed the fixup-public-ip-resource-count branch from 5f17fcd to 09f5680 Compare August 22, 2024 11:12
@apache apache deleted a comment from blueorangutan Aug 22, 2024
@vishesh92
Copy link
Copy Markdown
Member Author

vishesh92 commented Aug 22, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 22, 2024

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 22, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10750

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Aug 22, 2024

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 22, 2024

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 23, 2024

[SF] Trillian test result (tid-11142)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48166 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9563-t11142-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

DaanHoogland
DaanHoogland approved these changes Sep 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, i'll try to reproduce (issue and fix)

@DaanHoogland DaanHoogland self-assigned this Sep 3, 2024
@yadvr yadvr added this to the 4.19.2.0 milestone Sep 4, 2024
@yadvr yadvr requested a review from kiranchavala September 5, 2024 04:11
@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Sep 19, 2024

before:

for i in 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 ; do   cmk associate ipaddress account=ACSUser domainid=0138c7b1-75d6-11ef-85da-1e00d40003a2 networkid=60a9f348-5d07-4614-a2b3-4422f48c4972 zoneid=93d46e79-8af4-429c-adec-da9500ab16ea ipaddress=10.0.54.$i & done

leads to
Screenshot from 2024-09-19 10-39-29
Screenshot from 2024-09-19 10-39-52

after applying the patch I tried several times to get more than one IP address, with the above script, but failed.

@DaanHoogland DaanHoogland merged commit e16a971 into apache:4.19 Sep 19, 2024
@DaanHoogland DaanHoogland deleted the fixup-public-ip-resource-count branch September 19, 2024 09:38
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 23, 2024
@vishesh92 @dhslove
Fix resource count discrepancy while associating IP address to a netw…
ff83f4e 
…ork or vpc (apache#9563)
@DaanHoogland DaanHoogland removed their assignment Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

@kiranchavala kiranchavala Awaiting requested review from kiranchavala

Assignees

No one assigned

Labels

component:api component:networking component:vpc

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

Race condition in resource count while associating IP address to a network

5 participants

@vishesh92 @blueorangutan @sureshanaparti @DaanHoogland @yadvr