API: Fix missing keys in listZonesMetrics response by vishesh92 · Pull Request #9419 · apache/cloudstack

vishesh92 · 2024-07-19T08:00:16Z

Description

This PR fixes #9379
Fix missing keys in listZonesMetrics.

We use BeanUtils.copyProperties to copy the properties of ZoneResponse to ZoneMetricsResponse. Fields with missing getters are skipped from the response because of this.

cloudstack/plugins/metrics/src/main/java/org/apache/cloudstack/metrics/MetricsServiceImpl.java

Line 930 in 56c661c

BeanUtils.copyProperties(metricsResponse, zoneResponse);

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

vishesh92 · 2024-07-19T08:00:29Z

@blueorangutan package

blueorangutan · 2024-07-19T08:02:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-07-19T08:10:54Z

Codecov Report

Attention: Patch coverage is 0% with 123 lines in your changes missing coverage. Please review.

Project coverage is 15.07%. Comparing base (3faf7cd) to head (b3a2085).
Report is 2 commits behind head on 4.19.

Files	Patch %	Lines
...g/apache/cloudstack/api/response/HostResponse.java	0.00%	58 Missing ⚠️
...pache/cloudstack/api/response/ClusterResponse.java	0.00%	25 Missing ⚠️
...g/apache/cloudstack/api/response/ZoneResponse.java	0.00%	15 Missing ⚠️
...e/cloudstack/api/response/StoragePoolResponse.java	0.00%	9 Missing ⚠️
...apache/cloudstack/api/response/VolumeResponse.java	0.00%	6 Missing ⚠️
...udstack/api/response/ManagementServerResponse.java	0.00%	3 Missing ⚠️
...apache/cloudstack/api/response/UserVmResponse.java	0.00%	3 Missing ⚠️
.../java/com/cloud/api/query/dao/HostJoinDaoImpl.java	0.00%	2 Missing ⚠️
...src/main/java/com/cloud/api/ApiResponseHelper.java	0.00%	1 Missing ⚠️
...com/cloud/api/query/dao/DataCenterJoinDaoImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##               4.19    #9419     +/-   ##
===========================================
  Coverage     15.07%   15.07%             
- Complexity    11169    11172      +3     
===========================================
  Files          5405     5405             
  Lines        472677   472776     +99     
  Branches      60822    58920   -1902     
===========================================
+ Hits          71266    71290     +24     
- Misses       393484   393556     +72     
- Partials       7927     7930      +3

Flag	Coverage Δ
uitests	`4.27% <ø> (ø)`
unittests	`15.79% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-07-19T09:15:34Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10408

api/src/main/java/org/apache/cloudstack/api/response/ZoneResponse.java

yadvr · 2024-07-19T11:29:39Z

@vishesh92 LGTM didn't test it, can you raise this for 4.19 branch?

DaanHoogland

clgtm

github-actions · 2024-07-19T11:58:10Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

vishesh92 · 2024-07-19T12:02:26Z

@blueorangutan package

blueorangutan · 2024-07-19T12:04:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-07-19T13:01:42Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10412

yadvr · 2024-07-22T08:03:16Z

@vishesh92 also worth checking for list APIs & list metrics APIs for cluster and host? (and may VM and volumes)?

@blueorangutan test

blueorangutan · 2024-07-22T08:04:03Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-07-22T23:29:45Z

[SF] Trillian test result (tid-10930)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 54045 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9419-t10930-kvm-centos7.zip
Smoke tests completed. 130 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_04_nonsecured_to_secured_vm_migration	`Error`	427.38	test_vm_life_cycle.py
test_05_rvpc_multi_tiers	`Failure`	509.72	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	509.74	test_vpc_redundant.py

vishesh92 · 2024-07-23T19:45:20Z

@blueorangutan package

blueorangutan · 2024-07-23T19:46:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-07-23T20:50:30Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10449

vishesh92 · 2024-07-24T10:08:49Z

@blueorangutan test rocky8 kvm-rocky8

blueorangutan · 2024-07-24T10:10:04Z

@vishesh92 a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

blueorangutan · 2024-07-25T00:36:47Z

[SF] Trillian test result (tid-10955)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 50027 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9419-t10955-kvm-rocky8.zip
Smoke tests completed. 131 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	`Error`	134.40	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	134.40	test_vm_life_cycle.py

yadvr

LGTM, the changes are only (a) getters, (b) typo fixes and (c) Boolean -> boolean

This PR fixes apache#9379 Fix missing keys in listZonesMetrics. We use BeanUtils.copyProperties to copy the properties of ZoneResponse to ZoneMetricsResponse. Fields with missing getters are skipped from the response because of this.

boring-cyborg bot added the component:api label Jul 19, 2024

DaanHoogland reviewed Jul 19, 2024

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/response/ZoneResponse.java Outdated Show resolved Hide resolved

vishesh92 force-pushed the fix-zones-metrics-response branch from 8a93977 to b211c17 Compare July 19, 2024 10:56

yadvr added this to the 4.19.2.0 milestone Jul 19, 2024

DaanHoogland approved these changes Jul 19, 2024

View reviewed changes

vishesh92 changed the base branch from main to 4.19 July 19, 2024 11:57

boring-cyborg bot added component:agent component:build component:integration labels Jul 19, 2024

github-actions bot added the status:has-conflicts label Jul 19, 2024

Fix missing keys in listZonesMetrics response

1cc2854

vishesh92 force-pushed the fix-zones-metrics-response branch from b211c17 to 1cc2854 Compare July 19, 2024 12:02

github-actions bot removed the status:has-conflicts label Jul 19, 2024

yadvr approved these changes Jul 22, 2024

View reviewed changes

Fix & add response getters and setters

b3a2085

yadvr approved these changes Jul 29, 2024

View reviewed changes

yadvr merged commit f0ba905 into apache:4.19 Jul 29, 2024

yadvr deleted the fix-zones-metrics-response branch July 29, 2024 05:24

yadvr mentioned this pull request Jul 29, 2024

Zone UI view does not show SG & local storage details #9379

Closed

shwstppr mentioned this pull request Jan 22, 2025

UI: Toggle button for Local storage is not persistent #9821

Closed

Conversation

vishesh92 commented Jul 19, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

vishesh92 commented Jul 19, 2024

Uh oh!

blueorangutan commented Jul 19, 2024

Uh oh!

codecov bot commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jul 19, 2024

Uh oh!

Uh oh!

yadvr commented Jul 19, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 19, 2024

Uh oh!

vishesh92 commented Jul 19, 2024

Uh oh!

blueorangutan commented Jul 19, 2024

Uh oh!

blueorangutan commented Jul 19, 2024

Uh oh!

yadvr commented Jul 22, 2024

Uh oh!

blueorangutan commented Jul 22, 2024

Uh oh!

blueorangutan commented Jul 22, 2024

Uh oh!

vishesh92 commented Jul 23, 2024

Uh oh!

blueorangutan commented Jul 23, 2024

Uh oh!

blueorangutan commented Jul 23, 2024

Uh oh!

vishesh92 commented Jul 24, 2024

Uh oh!

blueorangutan commented Jul 24, 2024

Uh oh!

blueorangutan commented Jul 25, 2024

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jul 19, 2024 •

edited

Loading